This patch modifies only test cases.
Converted the MMA test cases to use opaque pointers.
Details
- Reviewers
nemanjai lei • Ahsan amyk - Group Reviewers
Restricted Project - Commits
- rG475a39fbc3c7: [PowerPC][NFC] Convert the MMA test cases to use opaque pointers.
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
1 missed bitcast, otherwise LGTM
| llvm/test/CodeGen/PowerPC/mma-intrinsics.ll | ||
|---|---|---|
| 616–618 | is this bitcast still needed? | |
I agree with Lei - LGTM, with some minor questions.
| llvm/test/CodeGen/PowerPC/mma-integer-based-outer-product.ll | ||
|---|---|---|
| 10 | If %vqp and %vpp are not used, do we still need to keep them? | |
| 40 | If %vqp and %vpp are not used, do we still need to keep them? | |
| 70 | If %vpp is not used, do we still need to keep them? (Here and in the functions below) | |
| llvm/test/CodeGen/PowerPC/mma-integer-based-outer-product.ll | ||
|---|---|---|
| 70 | You are correct that this is not used. The reason I chose not to do this cleanup was because that was not really the point of this patch and because it would be a fairly significant change and so the much larger diff would distract from the rest of the changes. I could however do this as a later patch. | |
| llvm/test/CodeGen/PowerPC/mma-intrinsics.ll | ||
| 616–618 | No, it's not needed. I think I missed that on my fist pass through. | |
If %vqp and %vpp are not used, do we still need to keep them?