This is an archive of the discontinued LLVM Phabricator instance.

[libc++][doc] Updates the release notes.
ClosedPublic

Authored by Mordante on Jul 18 2022, 11:33 AM.

Details

Summary

This is a preparation for the upcoming LLVM 16 release.

Diff Detail

Event Timeline

Mordante created this revision.Jul 18 2022, 11:33 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 18 2022, 11:33 AM
Mordante published this revision for review.Jul 18 2022, 11:44 AM

I've update the release notes and would like to land them before LLVM 16 is branched on July 26th.

If there are other missing features you want to mention, just add them as a review comment.

I haven't added -fexperimental-library, since these patches will update the release notes.

libcxx/docs/ReleaseNotes.rst
39

I think the experimental library is something we can add here too.

46

What will the status of ranges become?

129–130

Are these changes reverted too?

135

IIRC this change has been reverted. Or did we reland a new version?

Herald added a project: Restricted Project. · View Herald TranscriptJul 18 2022, 11:44 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
philnik added inline comments.Jul 18 2022, 2:05 PM
libcxx/docs/ReleaseNotes.rst
43

Complete nit, but maybe use format library? The first thought for me was "the whole library?".

46

I think the plan is to make ranges stable.

52–78

I'd like to have some visual indicator that the text is the title of the paper. How about P1234R5 - This is a really fascinating paper?

99–100
129–130

Yes, the transitive includes of public headers are (almost?) a superset of the ones included in LLVM 14.

238–239

Use the Oxford comma consistently or don't use it at all.

Thanks for the review! I'll give others some time to chime in before addressing the issues.

libcxx/docs/ReleaseNotes.rst
46

I heard the same plan ;-) but I'm not deeply involved in that part of the code so I don't know the exact status. Even less involved nowadays since we now have three people very active in ranges area :-)

52–78

I don't mind a visual indicator, but I felt the parenthesis felt odd. I expect most users will care about the title instead of the number. I'll add them in the next iteration.

129–130

Thanks! Then I'll remove this line.

ldionne accepted this revision.Jul 20 2022, 7:57 AM

LGTM, let's please land this ASAP, I'd like to propose a slight reorganization of the sections.

libcxx/docs/ReleaseNotes.rst
46

I discussed with @var-const yesterday and we tentatively agreed that due to the branch being cut earlier than expected and to finding a few important issues (like the issue with proxy iterators pointed by @huixie90), we feel that Ranges should stay experimental in LLVM 15, as we request user feedback. Furthermore, since we now have a well defined way to enable experimental features (-fexperimental-library), users can try it out easily.

So I'd keep this as experimental in the release notes unless we change our mind.

112
135

Please don't touch this release note, I will update it when I land D126823.

This revision is now accepted and ready to land.Jul 20 2022, 7:57 AM
Mordante marked 8 inline comments as done.Jul 20 2022, 9:06 AM

LGTM, let's please land this ASAP, I'd like to propose a slight reorganization of the sections.

Thanks for the review. I'll land it after I address all comments.

libcxx/docs/ReleaseNotes.rst
46

Thanks for the status update!

135

A thanks! I recalled wanted to reenable them, but I couldn't find the commit.

This revision was automatically updated to reflect the committed changes.
Mordante marked an inline comment as done.