This is an archive of the discontinued LLVM Phabricator instance.

Differential D129631

[ARM] Add Tag_CPU_arch missing value descriptions in attribute parser
ClosedPublic

Authored by vhscampos on Jul 13 2022, 3:40 AM.

Details

Reviewers
stuij
SjoerdMeijer
pratlucas
Commits
rGb43bec19b975: [ARM] Add Tag_CPU_arch missing value descriptions in attribute parser
Summary

The ARM attribute parser for Tag_CPU_arch is missing value descriptions
for Armv8-A and Armv8-R.

This patch adds these descriptions.

Diff Detail

Event Timeline

vhscampos created this revision.Jul 13 2022, 3:40 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 13 2022, 3:40 AM
Herald added subscribers: hiraditya, kristof.beyls. · View Herald Transcript
vhscampos requested review of this revision.Jul 13 2022, 3:40 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 13 2022, 3:40 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
vhscampos added reviewers: stuij, SjoerdMeijer, pratlucas.Jul 13 2022, 3:41 AM
pratlucas added a comment.Jul 13 2022, 3:59 AM

It'd be good to have a test covering the new values. Can you add one, please?

Harbormaster completed remote builds in B175077: Diff 444207.Jul 13 2022, 4:32 AM
vhscampos updated this revision to Diff 444242.Jul 13 2022, 6:05 AM

Adding testcases

vhscampos added a comment.Jul 13 2022, 6:06 AM

I can't think of a way to test multiple Tag_CPU_arch values in the same test file. So I created one test file for each CPU arch that I touched.

pratlucas accepted this revision.Jul 13 2022, 6:31 AM

LGTM.

This revision is now accepted and ready to land.Jul 13 2022, 6:31 AM
Harbormaster completed remote builds in B175098: Diff 444242.Jul 13 2022, 7:12 AM
Matt added a subscriber: Matt.Jul 13 2022, 5:03 PM
This revision was landed with ongoing or failed builds.Jul 26 2022, 12:32 AM
Closed by commit rGb43bec19b975: [ARM] Add Tag_CPU_arch missing value descriptions in attribute parser (authored by vhscampos). · Explain Why
This revision was automatically updated to reflect the committed changes.
vhscampos added a commit: rGb43bec19b975: [ARM] Add Tag_CPU_arch missing value descriptions in attribute parser.

Revision Contents

Diff 447592

llvm/lib/Support/ARMAttributeParser.cpp

Show First 20 Lines • Show All 79 Lines • ▼ Show 20 LinesError ARMAttributeParser::stringAttribute(AttrType tag) {
} }
return Error::success(); return Error::success();
} }
Error ARMAttributeParser::CPU_arch(AttrType tag) { Error ARMAttributeParser::CPU_arch(AttrType tag) {
static const char *strings[] = { static const char *strings[] = {
"Pre-v4", "ARM v4", "ARM v4T", "ARM v5T", "ARM v5TE", "ARM v5TEJ", "ARM v6", "Pre-v4", "ARM v4", "ARM v4T", "ARM v5T", "ARM v5TE", "ARM v5TEJ", "ARM v6",
"ARM v6KZ", "ARM v6T2", "ARM v6K", "ARM v7", "ARM v6-M", "ARM v6S-M", "ARM v6KZ", "ARM v6T2", "ARM v6K", "ARM v7", "ARM v6-M", "ARM v6S-M",
"ARM v7E-M", "ARM v8", nullptr, "ARM v7E-M", "ARM v8-A", "ARM v8-R",
"ARM v8-M Baseline", "ARM v8-M Mainline", nullptr, nullptr, nullptr, "ARM v8-M Baseline", "ARM v8-M Mainline", nullptr, nullptr, nullptr,
"ARM v8.1-M Mainline", "ARM v9-A" "ARM v8.1-M Mainline", "ARM v9-A"
}; };
return parseStringAttribute("CPU_arch", tag, makeArrayRef(strings)); return parseStringAttribute("CPU_arch", tag, makeArrayRef(strings));
} }
Error ARMAttributeParser::CPU_arch_profile(AttrType tag) { Error ARMAttributeParser::CPU_arch_profile(AttrType tag) {
uint64_t value = de.getULEB128(cursor); uint64_t value = de.getULEB128(cursor);
▲ Show 20 Lines • Show All 301 Lines • Show Last 20 Lines

llvm/test/MC/ARM/directive-eabi_attribute-cpu_arch-armv8a.s

  • This file was added.
@ RUN: llvm-mc -triple arm -filetype asm -o - %s | FileCheck %s
@ RUN: llvm-mc -triple arm -filetype obj -o - %s | llvm-readobj -A - | \
@ RUN: FileCheck %s --check-prefix=CHECK-OBJ
.eabi_attribute Tag_CPU_arch, 14
@ CHECK: .eabi_attribute 6, 14 @ Tag_CPU_arch
@ CHECK-OBJ: Attribute
@ CHECK-OBJ: Tag: 6
@ CHECK-OBJ-NEXT: Value: 14
@ CHECK-OBJ-NEXT: TagName: CPU_arch
@ CHECK-OBJ-NEXT: Description: ARM v8-A

llvm/test/MC/ARM/directive-eabi_attribute-cpu_arch-armv8r.s

  • This file was added.
@ RUN: llvm-mc -triple arm -filetype asm -o - %s | FileCheck %s
@ RUN: llvm-mc -triple arm -filetype obj -o - %s | llvm-readobj -A - | \
@ RUN: FileCheck %s --check-prefix=CHECK-OBJ
.eabi_attribute Tag_CPU_arch, 15
@ CHECK: .eabi_attribute 6, 15 @ Tag_CPU_arch
@ CHECK-OBJ: Attribute
@ CHECK-OBJ: Tag: 6
@ CHECK-OBJ-NEXT: Value: 15
@ CHECK-OBJ-NEXT: TagName: CPU_arch
@ CHECK-OBJ-NEXT: Description: ARM v8-R