This is an archive of the discontinued LLVM Phabricator instance.

Differential D129590

Change shebang from python to python3 in update_cc_test_checks.py
ClosedPublic

Authored by rusyaev-roman on Jul 12 2022, 1:30 PM.

Download Raw Diff

Details

Reviewers

MaskRay
barannikov88
lebedev.ri
mtrofin

Commits

rG9f70869545cf: Change shebang from python to python3 in update_cc_test_checks.py

Summary

All update_test_checks.py scripts were updated in this revision
https://reviews.llvm.org/D70730 except for update_cc_test_checks.py.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

rusyaev-roman created this revision.Jul 12 2022, 1:30 PM

Herald added a project: Restricted Project. · View Herald TranscriptJul 12 2022, 1:30 PM

rusyaev-roman requested review of this revision.Jul 12 2022, 1:30 PM

Herald added a project: Restricted Project. · View Herald TranscriptJul 12 2022, 1:30 PM

Herald added a subscriber: llvm-commits. · View Herald Transcript

rusyaev-roman added a reviewer: MaskRay.Jul 12 2022, 1:45 PM

Herald added a subscriber: StephenFan. · View Herald TranscriptJul 12 2022, 1:45 PM

LGTM

This revision is now accepted and ready to land.Jul 12 2022, 1:54 PM

I have no permission to merge. @MaskRay could you merge please?

rusyaev-roman added reviewers: lebedev.ri, mtrofin.Jul 12 2022, 10:31 PM

ping

In D129590#3649547, @rusyaev-roman wrote:

ping

I can merge it!

I can merge it!

It would be great. Thanks.

This revision was landed with ongoing or failed builds.Jul 13 2022, 1:03 PM

Closed by commit rG9f70869545cf: Change shebang from python to python3 in update_cc_test_checks.py (authored by rusyaev-roman, committed by mtrofin). · Explain Why

This revision was automatically updated to reflect the committed changes.

mtrofin added a commit: rG9f70869545cf: Change shebang from python to python3 in update_cc_test_checks.py.

In D129590#3649568, @rusyaev-roman wrote:

I can merge it!

It would be great. Thanks.

Done - thanks for fixing this, too!

RKSimon mentioned this in D78028: move shebangs from python2 to python3.Jan 20 2023, 4:25 AM

Revision Contents

Path

Size

llvm/

utils/

update_cc_test_checks.py

2 lines

Diff 444399

llvm/utils/update_cc_test_checks.py

	#!/usr/bin/env python			#!/usr/bin/env python3
	'''A utility to update LLVM IR CHECK lines in C/C++ FileCheck test files.			'''A utility to update LLVM IR CHECK lines in C/C++ FileCheck test files.

	Example RUN lines in .c/.cc test files:			Example RUN lines in .c/.cc test files:

	// RUN: %clang -emit-llvm -S %s -o - -O2 \| FileCheck %s			// RUN: %clang -emit-llvm -S %s -o - -O2 \| FileCheck %s
	// RUN: %clangxx -emit-llvm -S %s -o - -O2 \| FileCheck -check-prefix=CHECK-A %s			// RUN: %clangxx -emit-llvm -S %s -o - -O2 \| FileCheck -check-prefix=CHECK-A %s

	Usage:			Usage:
	▲ Show 20 Lines • Show All 413 Lines • Show Last 20 Lines