Page MenuHomePhabricator

rusyaev-roman (Roman Rusyaev)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 10 2022, 12:03 PM (11 w, 2 h)

Recent Activity

Aug 11 2022

rusyaev-roman added inline comments to D131448: Introduce iterator sentinel to make graph traversal implementation more efficient and cleaner.
Aug 11 2022, 11:46 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
rusyaev-roman added a comment to D131448: Introduce iterator sentinel to make graph traversal implementation more efficient and cleaner.

For a while I will be in a place where the Internet does not work well. I'll finish the patch when I come back.

Aug 11 2022, 11:45 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
rusyaev-roman added a comment to D131448: Introduce iterator sentinel to make graph traversal implementation more efficient and cleaner.

First of all, thank you for your feedback! I've tried to address all your comments.

Aug 11 2022, 12:45 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Aug 10 2022

rusyaev-roman added reviewers for D131448: Introduce iterator sentinel to make graph traversal implementation more efficient and cleaner: dblaikie, lattner.
Aug 10 2022, 2:51 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Aug 9 2022

rusyaev-roman added a comment to D131448: Introduce iterator sentinel to make graph traversal implementation more efficient and cleaner.

In sum, this change brings the following improvements for all graph traversal iterators that are used in 'range-based for loop':

  • avoid creating an empty iterator (that holds containers inside) to compare with the end iterator
  • make 'empty()' call explicit (instead of comparing two containers of iterators) when an iterator is compared with the end iterator
Aug 9 2022, 10:47 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
rusyaev-roman updated the diff for D131448: Introduce iterator sentinel to make graph traversal implementation more efficient and cleaner.

Fix mlir build and rebase

Aug 9 2022, 10:42 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Aug 8 2022

rusyaev-roman added reviewers for D131448: Introduce iterator sentinel to make graph traversal implementation more efficient and cleaner: craig.topper, dexonsmith, wristow, hoy, thieta.
Aug 8 2022, 3:45 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
rusyaev-roman requested review of D131448: Introduce iterator sentinel to make graph traversal implementation more efficient and cleaner.
Aug 8 2022, 3:13 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Aug 7 2022

rusyaev-roman accepted D131329: [SDAG] Add `getCALLSEQ_END` overload taking `uint64_t`s.

lgtm

Aug 7 2022, 9:03 AM · Restricted Project, Restricted Project
rusyaev-roman accepted D130394: [clang][CodeGen] Factor out Swift ABI hooks (NFCI).

LGTM. Maybe in the future it's better to use SwiftABIInfo as mix-in like this

Aug 7 2022, 8:57 AM · Restricted Project, Restricted Project

Jul 26 2022

rusyaev-roman added inline comments to D119792: [Clang] [P2025] Analyze only potential scopes for NRVO.
Jul 26 2022, 1:34 AM · Restricted Project, Restricted Project
rusyaev-roman added inline comments to D119792: [Clang] [P2025] Analyze only potential scopes for NRVO.
Jul 26 2022, 12:26 AM · Restricted Project, Restricted Project
rusyaev-roman added inline comments to D119792: [Clang] [P2025] Analyze only potential scopes for NRVO.
Jul 26 2022, 12:21 AM · Restricted Project, Restricted Project
rusyaev-roman added inline comments to D119792: [Clang] [P2025] Analyze only potential scopes for NRVO.
Jul 26 2022, 12:18 AM · Restricted Project, Restricted Project
rusyaev-roman added a comment to D119792: [Clang] [P2025] Analyze only potential scopes for NRVO.

@ChuanqiXu , the release notes were updated. Could you check and merge please?

Jul 26 2022, 12:16 AM · Restricted Project, Restricted Project
rusyaev-roman updated the diff for D119792: [Clang] [P2025] Analyze only potential scopes for NRVO.

Add a release note.

Jul 26 2022, 12:15 AM · Restricted Project, Restricted Project
rusyaev-roman added inline comments to D119792: [Clang] [P2025] Analyze only potential scopes for NRVO.
Jul 26 2022, 12:07 AM · Restricted Project, Restricted Project

Jul 25 2022

rusyaev-roman added inline comments to D119792: [Clang] [P2025] Analyze only potential scopes for NRVO.
Jul 25 2022, 11:33 PM · Restricted Project, Restricted Project
rusyaev-roman added inline comments to D119792: [Clang] [P2025] Analyze only potential scopes for NRVO.
Jul 25 2022, 11:28 PM · Restricted Project, Restricted Project
rusyaev-roman added inline comments to D119792: [Clang] [P2025] Analyze only potential scopes for NRVO.
Jul 25 2022, 11:18 PM · Restricted Project, Restricted Project
rusyaev-roman added inline comments to D119792: [Clang] [P2025] Analyze only potential scopes for NRVO.
Jul 25 2022, 10:29 PM · Restricted Project, Restricted Project
rusyaev-roman added a comment to D119792: [Clang] [P2025] Analyze only potential scopes for NRVO.

@ChuanqiXu , I've added additional comments. Could you check again please?

Jul 25 2022, 2:03 PM · Restricted Project, Restricted Project
rusyaev-roman updated the diff for D119792: [Clang] [P2025] Analyze only potential scopes for NRVO.

Rebase and add additional comments.

Jul 25 2022, 1:42 PM · Restricted Project, Restricted Project
rusyaev-roman added inline comments to D119792: [Clang] [P2025] Analyze only potential scopes for NRVO.
Jul 25 2022, 1:40 PM · Restricted Project, Restricted Project

Jul 24 2022

rusyaev-roman added a comment to D119792: [Clang] [P2025] Analyze only potential scopes for NRVO.

@ChuanqiXu , could you take a look again? I've updated the original implementation.

Jul 24 2022, 11:59 PM · Restricted Project, Restricted Project
rusyaev-roman updated the diff for D119792: [Clang] [P2025] Analyze only potential scopes for NRVO.

Update the origianl implementation.

Jul 24 2022, 2:21 PM · Restricted Project, Restricted Project
rusyaev-roman updated the diff for D119792: [Clang] [P2025] Analyze only potential scopes for NRVO.

Rebase

Jul 24 2022, 1:48 PM · Restricted Project, Restricted Project
rusyaev-roman commandeered D119792: [Clang] [P2025] Analyze only potential scopes for NRVO.
Jul 24 2022, 1:47 PM · Restricted Project, Restricted Project

Jul 21 2022

rusyaev-roman added a comment to D129935: [TableGen] Add a location for a class definition that was forward-declared.

My concern here is with the behavior of PrintMessage and friends. The original change would produce misleading output there. WIth the current change, PrintMessage will print the location of the definition (if it is known).

Jul 21 2022, 5:15 AM · Restricted Project, Restricted Project

Jul 20 2022

rusyaev-roman added a comment to D129935: [TableGen] Add a location for a class definition that was forward-declared.

Right you are, sorry for my confusion. The patch isn't quite right because it overrides the current meaning of the Locs array (which is to track multiclass instantiations), and that can lead to confusion e.g. with PrintMessage. I took the liberty of making some adjustments before committing the patch (394a388d140dc9e74178532501cddb558a589398)

Jul 20 2022, 9:14 AM · Restricted Project, Restricted Project
rusyaev-roman added a comment to D129935: [TableGen] Add a location for a class definition that was forward-declared.

Thanks for the patch. Could you please add a test case?

Jul 20 2022, 1:45 AM · Restricted Project, Restricted Project

Jul 19 2022

rusyaev-roman added a comment to D129935: [TableGen] Add a location for a class definition that was forward-declared.

@silvas @nhaehnle @sunfish Could you take a look at this patch and then merge it please? I have no permission.

Jul 19 2022, 11:08 AM · Restricted Project, Restricted Project
rusyaev-roman added a reviewer for D129935: [TableGen] Add a location for a class definition that was forward-declared: sunfish.
Jul 19 2022, 11:06 AM · Restricted Project, Restricted Project

Jul 18 2022

rusyaev-roman updated the diff for D129935: [TableGen] Add a location for a class definition that was forward-declared.

Rebase

Jul 18 2022, 11:39 AM · Restricted Project, Restricted Project
rusyaev-roman added a comment to D119792: [Clang] [P2025] Analyze only potential scopes for NRVO.

Hi!

Unfortunately I don't have time to finish this pull request, so please feel free to take it and get it done =)

(You may reuse the code from this PR or write a completely new implementation)

Jul 18 2022, 11:35 AM · Restricted Project, Restricted Project

Jul 17 2022

rusyaev-roman added a reviewer for D129935: [TableGen] Add a location for a class definition that was forward-declared: nhaehnle.
Jul 17 2022, 11:17 AM · Restricted Project, Restricted Project
rusyaev-roman added a comment to D129935: [TableGen] Add a location for a class definition that was forward-declared.

This failure is not related to my changes

Jul 17 2022, 3:48 AM · Restricted Project, Restricted Project

Jul 16 2022

rusyaev-roman updated the diff for D129935: [TableGen] Add a location for a class definition that was forward-declared.

Rebased

Jul 16 2022, 11:16 PM · Restricted Project, Restricted Project
rusyaev-roman updated the summary of D129935: [TableGen] Add a location for a class definition that was forward-declared.
Jul 16 2022, 11:59 AM · Restricted Project, Restricted Project
rusyaev-roman updated the diff for D129935: [TableGen] Add a location for a class definition that was forward-declared.

Removed unsed 'private' access specifier.

Jul 16 2022, 11:58 AM · Restricted Project, Restricted Project
rusyaev-roman updated the summary of D129935: [TableGen] Add a location for a class definition that was forward-declared.
Jul 16 2022, 11:43 AM · Restricted Project, Restricted Project
rusyaev-roman updated the diff for D129935: [TableGen] Add a location for a class definition that was forward-declared.

changed commit message

Jul 16 2022, 11:43 AM · Restricted Project, Restricted Project
rusyaev-roman added a reviewer for D129935: [TableGen] Add a location for a class definition that was forward-declared: silvas.
Jul 16 2022, 11:28 AM · Restricted Project, Restricted Project
rusyaev-roman requested review of D129935: [TableGen] Add a location for a class definition that was forward-declared.
Jul 16 2022, 11:17 AM · Restricted Project, Restricted Project

Jul 13 2022

rusyaev-roman added a comment to D129590: Change shebang from python to python3 in update_cc_test_checks.py.

I can merge it!

Jul 13 2022, 1:00 PM · Restricted Project, Restricted Project
rusyaev-roman added a comment to D129590: Change shebang from python to python3 in update_cc_test_checks.py.

ping

Jul 13 2022, 12:56 PM · Restricted Project, Restricted Project

Jul 12 2022

rusyaev-roman added reviewers for D129590: Change shebang from python to python3 in update_cc_test_checks.py: lebedev.ri, mtrofin.
Jul 12 2022, 10:31 PM · Restricted Project, Restricted Project
rusyaev-roman added a comment to D129590: Change shebang from python to python3 in update_cc_test_checks.py.

I have no permission to merge. @MaskRay could you merge please?

Jul 12 2022, 1:59 PM · Restricted Project, Restricted Project
rusyaev-roman added a reviewer for D129590: Change shebang from python to python3 in update_cc_test_checks.py: MaskRay.
Jul 12 2022, 1:45 PM · Restricted Project, Restricted Project
rusyaev-roman requested review of D129590: Change shebang from python to python3 in update_cc_test_checks.py.
Jul 12 2022, 1:30 PM · Restricted Project, Restricted Project