Page MenuHomePhabricator

[mlir][Linalg] Make SplitReduction use bufferize::AllocTensor
ClosedPublic

Authored by nicolasvasilache on Jun 28 2022, 5:27 AM.

Details

Summary

SplitReduction is known to require a concrete additional buffer
to store tempoaray information.
Modify it to introduce a bufferization.alloc_tensor.
This behaves better with subset-based tiling and bufferization.

Diff Detail

Event Timeline

Herald added a reviewer: aartbik. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
nicolasvasilache requested review of this revision.Jun 28 2022, 5:27 AM

Drop spurious files.

Fix missing paren.

ThomasRaoux accepted this revision.Jun 28 2022, 8:54 AM
This revision is now accepted and ready to land.Jun 28 2022, 8:54 AM
mravishankar requested changes to this revision.Jun 28 2022, 8:58 AM

I am not sure introducing an allocation semantics op at this level makes sense for all use cases. AFAICS, the bufferization allocation op should only be introduced "close to bufferization" and that might not be the case for all use cases. Definitely is not the case for within IREE. At the very least it should be optional to use this op.

This revision now requires changes to proceed.Jun 28 2022, 8:58 AM

Refactor transforms and make alloc_tensor optional.

I am not sure introducing an allocation semantics op at this level makes sense for all use cases. AFAICS, the bufferization allocation op should only be introduced "close to bufferization" and that might not be the case for all use cases. Definitely is not the case for within IREE. At the very least it should be optional to use this op.

Turned it into an option,.

This revision was not accepted when it landed; it landed in state Needs Review.Jun 30 2022, 3:32 AM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.