Page MenuHomePhabricator

[MLIR] Add LLVM_NODISCARD to MLIR builders for types and attributes.
Needs ReviewPublic

Authored by frgossen on Jun 22 2022, 9:01 AM.

Details

Summary

Building a type or an attribute w/o using the value is almost certainly a bug.

Diff Detail

Event Timeline

frgossen created this revision.Jun 22 2022, 9:01 AM
Herald added a project: Restricted Project. · View Herald Transcript
frgossen requested review of this revision.Jun 22 2022, 9:01 AM

Could you add rationale to description?

frgossen edited the summary of this revision. (Show Details)Jun 22 2022, 1:28 PM

Added rationale

frgossen retitled this revision from Add LLVM_NODISCARD to MLIR builders for types and attributes. to [MLIR] Add LLVM_NODISCARD to MLIR builders for types and attributes..Jun 22 2022, 1:30 PM

We don't need to touch the declarations in the .h at all?