This is an archive of the discontinued LLVM Phabricator instance.

[iwyu] Handle regressions in libLLVM header include
ClosedPublic

Authored by serge-sans-paille on Jun 22 2022, 7:23 AM.

Details

Summary

Running iwyu-diff on LLVM codebase since fb67d683db46dfd88da09d99 detected a few
regressions, fixing them.

The impact on preprocessed output is negligible: -4k lines.

Diff Detail

Unit TestsFailed

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptJun 22 2022, 7:23 AM
serge-sans-paille requested review of this revision.Jun 22 2022, 7:23 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 22 2022, 7:23 AM
RKSimon accepted this revision.Jun 22 2022, 8:55 AM

LGTM - are these new (unnecessary) additions or has the code been changed to remove a dependency?

This revision is now accepted and ready to land.Jun 22 2022, 8:55 AM
MaskRay accepted this revision.Jun 22 2022, 5:20 PM

@RKSimon: I don't track the origin of the change, I can't tell...

oh, and I landed that one while forgetting to link it to phabricator, this patch landed as 27fd01d3f88c1996fc000b6e139b50a600879fde