When opaque pointers was enabled, -no-opaque-pointers were added to some tests in order not to change behaviour. We now revert this and fix the test.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
LGTM. Though it also looks like all the WEBASSEMBLY32/WEBASSEMBLY64 lines you're modifying match each other, so could be combined to single WEBASSEMBLY: lines. It might be worth doing that while you're touching this test?
clang/test/CodeGen/builtins-wasm.c | ||
---|---|---|
2 | Nit: whitespace. |
Comment Actions
I think the lines still differ in that one tests wasm32 and the other tests wasm64 (the triples are different).
Comment Actions
Yeah, but the convention used elsewhere in this test file is to use WEBASSEMBLY: (which is a common check prefix for both wasm32 and wasm64 run lines) in the cases where the output is the same.
Comment Actions
Ohh, for some reason I thought you were talking about the RUN lines. Yes, combining the check lines would make sense.
Nit: whitespace.