This patch builds on prior support patches to enable support for variadic debug values in InstrRefLDV, allowing DBG_VALUE_LISTs to have their ranges extended.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
Added some lit tests, specifically adding variadic test cases to the existing tests which explicitly test the instruction referencing LiveDebugValues.
Comment Actions
Hi Stephen,
This patch broke Linux kernel builds with KMSAN and -gdwarf-4. Reverting the patch fixes the problem.
Comment Actions
Hi, happy to revert until a fix is found; do you have any more information on the error?
Comment Actions
Hi Stephen,
The following command line crashes for me on the attached file: clang -std=gnu11 --target=x86_64-linux-gnu -fno-omit-frame-pointer -fsanitize=kernel-memory -fsanitize-memory-param-retval -fsanitize-coverage=trace-pc -fsanitize-coverage=trace-cmp -c extents.i -w -g -O2:
clang: /usr/local/google/src/llvm-git-monorepo/llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.cpp:808: void TransferTracker::clobberMloc(LiveDebugValues::LocIdx, LiveDebugValues::ValueIDNum, llvm::MachineBasicBlock::iterator, bool): Assertion `LostMLocIt->second.contains(LocVarIt.second) && "Variable was using this MLoc, but does not appear in " "ActiveMLocs?"' failed. PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace, preprocessed source, and associated run script. Stack dump: 0. Program arguments: /usr/local/google/src/llvm-git-monorepo/llvm_cmake_build/bin//clang -std=gnu11 --target=x86_64-linux-gnu -fno-omit-frame-pointer -fsanitize=kernel-memory -fsanitize-memory-param-retval -fsanitize-coverage=trace-pc -fsanitize-coverage=trace-cmp -c extents.i -w -g -O2 1. <eof> parser at end of file 2. Code generation 3. Running pass 'Function Pass Manager' on module 'extents.i'. 4. Running pass 'Live DEBUG_VALUE analysis' on function '@__ext4_ext_check' #0 0x0000559c52bd9d61 PrintStackTraceSignalHandler(void*) Signals.cpp:0:0 #1 0x0000559c52bd7b8c llvm::sys::CleanupOnSignal(unsigned long) (/usr/local/google/src/llvm-git-monorepo/llvm_cmake_build/bin//clang+0x3ce5b8c) #2 0x0000559c52b1a5e8 CrashRecoverySignalHandler(int) CrashRecoveryContext.cpp:0:0 #3 0x00007f0cf4b52200 __restore_rt (/lib/x86_64-linux-gnu/libpthread.so.0+0x12200) #4 0x00007f0cf45cb8c1 raise ./signal/../sysdeps/unix/sysv/linux/raise.c:50:1 #5 0x00007f0cf45b5546 abort ./stdlib/abort.c:81:7 #6 0x00007f0cf45b542f get_sysdep_segment_value ./intl/loadmsgcat.c:509:8 #7 0x00007f0cf45b542f _nl_load_domain ./intl/loadmsgcat.c:970:34 #8 0x00007f0cf45c4242 (/lib/x86_64-linux-gnu/libc.so.6+0x31242) #9 0x0000559c520e110f TransferTracker::clobberMloc(LiveDebugValues::LocIdx, LiveDebugValues::ValueIDNum, llvm::MachineInstrBundleIterator<llvm::MachineInstr, false>, bool) (/usr/local/google/src/llvm-git-monorepo/llvm_cmake_build/bin//clang+0x31ef10f) #10 0x0000559c520e165f TransferTracker::clobberMloc(LiveDebugValues::LocIdx, llvm::MachineInstrBundleIterator<llvm::MachineInstr, false>, bool) (/usr/local/google/src/llvm-git-monorepo/llvm_cmake_build/bin//clang+0x31ef65f) #11 0x0000559c520e18bb LiveDebugValues::InstrRefBasedLDV::transferSpillOrRestoreInst(llvm::MachineInstr&) (.part.0) InstrRefBasedImpl.cpp:0:0 #12 0x0000559c520e2185 LiveDebugValues::InstrRefBasedLDV::transferSpillOrRestoreInst(llvm::MachineInstr&) (/usr/local/google/src/llvm-git-monorepo/llvm_cmake_build/bin//clang+0x31f0185) #13 0x0000559c520f09ea LiveDebugValues::InstrRefBasedLDV::process(llvm::MachineInstr&, std::unique_ptr<LiveDebugValues::ValueIDNum [], std::default_delete<LiveDebugValues::ValueIDNum []>> const*, std::unique_ptr<LiveDebugValues::ValueIDNum [], std::default_delete<LiveDebugValues::ValueIDNum []>> const*) (/usr/local/google/src/llvm-git-monorepo/llvm_cmake_build/bin//clang+0x31fe9ea) #14 0x0000559c520f17ef LiveDebugValues::InstrRefBasedLDV::depthFirstVLocAndEmit(unsigned int, llvm::DenseMap<llvm::LexicalScope const*, llvm::DILocation const*, llvm::DenseMapInfo<llvm::LexicalScope const*, void>, llvm::detail::DenseMapPair<llvm::LexicalScope const*, llvm::DILocation const*>> const&, llvm::DenseMap<llvm::LexicalScope const*, llvm::SmallSet<llvm::DebugVariable, 4u, std::less<llvm::DebugVariable>>, llvm::DenseMapInfo<llvm::LexicalScope const*, void>, llvm::detail::DenseMapPair<llvm::LexicalScope const*, llvm::SmallSet<llvm::DebugVariable, 4u, std::less<llvm::DebugVariable>>>> const&, llvm::DenseMap<llvm::LexicalScope const*, llvm::SmallPtrSet<llvm::MachineBasicBlock*, 4u>, llvm::DenseMapInfo<llvm::LexicalScope const*, void>, llvm::detail::DenseMapPair<llvm::LexicalScope const*, llvm::SmallPtrSet<llvm::MachineBasicBlock*, 4u>>>&, llvm::SmallVector<llvm::SmallVector<std::pair<llvm::DebugVariable, LiveDebugValues::DbgValue>, 8u>, 8u>&, std::unique_ptr<std::unique_ptr<LiveDebugValues::ValueIDNum [], std::default_delete<LiveDebugValues::ValueIDNum []>> [], std::default_delete<std::unique_ptr<LiveDebugValues::ValueIDNum [], std::default_delete<LiveDebugValues::ValueIDNum []>> []>>&, std::unique_ptr<std::unique_ptr<LiveDebugValues::ValueIDNum [], std::default_delete<LiveDebugValues::ValueIDNum []>> [], std::default_delete<std::unique_ptr<LiveDebugValues::ValueIDNum [], std::default_delete<LiveDebugValues::ValueIDNum []>> []>>&, llvm::SmallVectorImpl<LiveDebugValues::VLocTracker>&, llvm::MachineFunction&, llvm::DenseMap<llvm::DebugVariable, unsigned int, llvm::DenseMapInfo<llvm::DebugVariable, void>, llvm::detail::DenseMapPair<llvm::DebugVariable, unsigned int>>&, llvm::TargetPassConfig const&)::'lambda'(llvm::MachineBasicBlock&)::operator()(llvm::MachineBasicBlock&) const InstrRefBasedImpl.cpp:0:0 #15 0x0000559c520f716d LiveDebugValues::InstrRefBasedLDV::depthFirstVLocAndEmit(unsigned int, llvm::DenseMap<llvm::LexicalScope const*, llvm::DILocation const*, llvm::DenseMapInfo<llvm::LexicalScope const*, void>, llvm::detail::DenseMapPair<llvm::LexicalScope const*, llvm::DILocation const*>> const&, llvm::DenseMap<llvm::LexicalScope const*, llvm::SmallSet<llvm::DebugVariable, 4u, std::less<llvm::DebugVariable>>, llvm::DenseMapInfo<llvm::LexicalScope const*, void>, llvm::detail::DenseMapPair<llvm::LexicalScope const*, llvm::SmallSet<llvm::DebugVariable, 4u, std::less<llvm::DebugVariable>>>> const&, llvm::DenseMap<llvm::LexicalScope const*, llvm::SmallPtrSet<llvm::MachineBasicBlock*, 4u>, llvm::DenseMapInfo<llvm::LexicalScope const*, void>, llvm::detail::DenseMapPair<llvm::LexicalScope const*, llvm::SmallPtrSet<llvm::MachineBasicBlock*, 4u>>>&, llvm::SmallVector<llvm::SmallVector<std::pair<llvm::DebugVariable, LiveDebugValues::DbgValue>, 8u>, 8u>&, std::unique_ptr<std::unique_ptr<LiveDebugValues::ValueIDNum [], std::default_delete<LiveDebugValues::ValueIDNum []>> [], std::default_delete<std::unique_ptr<LiveDebugValues::ValueIDNum [], std::default_delete<LiveDebugValues::ValueIDNum []>> []>>&, std::unique_ptr<std::unique_ptr<LiveDebugValues::ValueIDNum [], std::default_delete<LiveDebugValues::ValueIDNum []>> [], std::default_delete<std::unique_ptr<LiveDebugValues::ValueIDNum [], std::default_delete<LiveDebugValues::ValueIDNum []>> []>>&, llvm::SmallVectorImpl<LiveDebugValues::VLocTracker>&, llvm::MachineFunction&, llvm::DenseMap<llvm::DebugVariable, unsigned int, llvm::DenseMapInfo<llvm::DebugVariable, void>, llvm::detail::DenseMapPair<llvm::DebugVariable, unsigned int>>&, llvm::TargetPassConfig const&) (/usr/local/google/src/llvm-git-monorepo/llvm_cmake_build/bin//clang+0x320516d) #16 0x0000559c520fb700 LiveDebugValues::InstrRefBasedLDV::ExtendRanges(llvm::MachineFunction&, llvm::MachineDominatorTree*, llvm::TargetPassConfig*, unsigned int, unsigned int) (/usr/local/google/src/llvm-git-monorepo/llvm_cmake_build/bin//clang+0x3209700) #17 0x0000559c51de7da8 llvm::MachineFunctionPass::runOnFunction(llvm::Function&) (.part.0) MachineFunctionPass.cpp:0:0
Sorry, I haven't managed to reduce it further so far.
Comment Actions
Oh, actually creduce can do better:
struct b {
int c;
int d
};
struct e {
int f
};
int g;
void i();
void j(struct b *k) { i(k->d); }
int l(struct e *k) {
int a, b;
a = k->f;
struct b *h = k;
while (a) {
j(h);
if (g < b)
return 0;
h++;
a--;
b = g;
}
i(k);
}Comment Actions
I too saw a crash in the Linux kernel with this change (no KMSAN), my reduction just finished:
struct rb_node {
long __rb_parent_color;
} rb_erase(struct rb_node *, int *);
struct journal_node {
struct rb_node node;
long sector;
} * do_journal_write_ic_0;
short page_list_location_ic_2;
int page_list_location_section, page_list_location_pl_offset,
remove_journal_node_ic_1;
int *access_journal___trans_tmp_5;
unsigned do_journal_write_i;
void remove_journal_node(struct journal_node *node) {
if (__builtin_expect((&node->node)->__rb_parent_color == (long)node, 0))
asm(".pushsection __bug_table,\"aw\"\n"
".popsection\n");
rb_erase(&node->node, &remove_journal_node_ic_1);
}
_Bool find_newer_committed_node(struct journal_node *);
void do_journal_write() {
unsigned j;
for (;;) {
unsigned k;
struct journal_node *section_node =
&do_journal_write_ic_0[do_journal_write_i];
while (j < k && find_newer_committed_node(§ion_node[j])) {
unsigned sector =
page_list_location_section * page_list_location_ic_2 + j;
page_list_location_pl_offset = sector << *access_journal___trans_tmp_5;
remove_journal_node(§ion_node[j]);
j++;
}
while (k && find_newer_committed_node(§ion_node[k]))
k--;
}
}$ clang -O2 -gdwarf-5 -c -o /dev/null dm-integrity.i clang: /home/nathan/cbl/src/llvm-project/llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.cpp:810: void TransferTracker::clobberMloc(LocIdx, ValueIDNum, MachineBasicBlock::iterator, bool): Assertion `LostMLocIt->second.contains(LocVarIt.second) && "Variable was using this MLoc, but does not appear in " "ActiveMLocs?"' failed. PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace, preprocessed source, and associated run script. Stack dump: 0. Program arguments: clang -O2 -gdwarf-5 -c -o /dev/null dm-integrity.i 1. <eof> parser at end of file 2. Code generation 3. Running pass 'Function Pass Manager' on module 'dm-integrity.i'. 4. Running pass 'Live DEBUG_VALUE analysis' on function '@do_journal_write' #0 0x000055e8015a8a03 llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) (/home/nathan/tmp/tmp.gmGKPVYoUk/install/llvm/2cb9e1ac422f46de0ab728c6c9d50ebafbfe372a/bin/clang-16+0x312da03) #1 0x000055e8015a6a4e llvm::sys::RunSignalHandlers() (/home/nathan/tmp/tmp.gmGKPVYoUk/install/llvm/2cb9e1ac422f46de0ab728c6c9d50ebafbfe372a/bin/clang-16+0x312ba4e) #2 0x000055e80152bacf (anonymous namespace)::CrashRecoveryContextImpl::HandleCrash(int, unsigned long) CrashRecoveryContext.cpp:0:0 #3 0x000055e80152bce1 CrashRecoverySignalHandler(int) CrashRecoveryContext.cpp:0:0 #4 0x00007f6e6dc1da40 (/usr/lib/libc.so.6+0x38a40) #5 0x00007f6e6dc6d4dc (/usr/lib/libc.so.6+0x884dc) #6 0x00007f6e6dc1d998 raise (/usr/lib/libc.so.6+0x38998) #7 0x00007f6e6dc0753d abort (/usr/lib/libc.so.6+0x2253d) #8 0x00007f6e6dc0745c (/usr/lib/libc.so.6+0x2245c) #9 0x00007f6e6dc164c6 (/usr/lib/libc.so.6+0x314c6) #10 0x000055e800d383a8 TransferTracker::clobberMloc(LiveDebugValues::LocIdx, LiveDebugValues::ValueIDNum, llvm::MachineInstrBundleIterator<llvm::MachineInstr, false>, bool) InstrRefBasedImpl.cpp:0:0 #11 0x000055e800d3647d LiveDebugValues::InstrRefBasedLDV::transferSpillOrRestoreInst(llvm::MachineInstr&) (/home/nathan/tmp/tmp.gmGKPVYoUk/install/llvm/2cb9e1ac422f46de0ab728c6c9d50ebafbfe372a/bin/clang-16+0x28bb47d) #12 0x000055e800d47e83 LiveDebugValues::InstrRefBasedLDV::depthFirstVLocAndEmit(unsigned int, llvm::DenseMap<llvm::LexicalScope const*, llvm::DILocation const*, llvm::DenseMapInfo<llvm::LexicalScope const*, void>, llvm::detail::DenseMapPair<llvm::LexicalScope const*, llvm::DILocation const*>> const&, llvm::DenseMap<llvm::LexicalScope const*, llvm::SmallSet<llvm::DebugVariable, 4u, std::less<llvm::DebugVariable>>, llvm::DenseMapInfo<llvm::LexicalScope const*, void>, llvm::detail::DenseMapPair<llvm::LexicalScope const*, llvm::SmallSet<llvm::DebugVariable, 4u, std::less<llvm::DebugVariable>>>> const&, llvm::DenseMap<llvm::LexicalScope const*, llvm::SmallPtrSet<llvm::MachineBasicBlock*, 4u>, llvm::DenseMapInfo<llvm::LexicalScope const*, void>, llvm::detail::DenseMapPair<llvm::LexicalScope const*, llvm::SmallPtrSet<llvm::MachineBasicBlock*, 4u>>>&, llvm::SmallVector<llvm::SmallVector<std::pair<llvm::DebugVariable, LiveDebugValues::DbgValue>, 8u>, 8u>&, std::unique_ptr<std::unique_ptr<LiveDebugValues::ValueIDNum [], std::default_delete<LiveDebugValues::ValueIDNum []>> [], std::default_delete<std::unique_ptr<LiveDebugValues::ValueIDNum [], std::default_delete<LiveDebugValues::ValueIDNum []>> []>>&, std::unique_ptr<std::unique_ptr<LiveDebugValues::ValueIDNum [], std::default_delete<LiveDebugValues::ValueIDNum []>> [], std::default_delete<std::unique_ptr<LiveDebugValues::ValueIDNum [], std::default_delete<LiveDebugValues::ValueIDNum []>> []>>&, llvm::SmallVectorImpl<LiveDebugValues::VLocTracker>&, llvm::MachineFunction&, llvm::DenseMap<llvm::DebugVariable, unsigned int, llvm::DenseMapInfo<llvm::DebugVariable, void>, llvm::detail::DenseMapPair<llvm::DebugVariable, unsigned int>>&, llvm::TargetPassConfig const&)::$_13::operator()(llvm::MachineBasicBlock&) const InstrRefBasedImpl.cpp:0:0 #13 0x000055e800d4782d LiveDebugValues::InstrRefBasedLDV::depthFirstVLocAndEmit(unsigned int, llvm::DenseMap<llvm::LexicalScope const*, llvm::DILocation const*, llvm::DenseMapInfo<llvm::LexicalScope const*, void>, llvm::detail::DenseMapPair<llvm::LexicalScope const*, llvm::DILocation const*>> const&, llvm::DenseMap<llvm::LexicalScope const*, llvm::SmallSet<llvm::DebugVariable, 4u, std::less<llvm::DebugVariable>>, llvm::DenseMapInfo<llvm::LexicalScope const*, void>, llvm::detail::DenseMapPair<llvm::LexicalScope const*, llvm::SmallSet<llvm::DebugVariable, 4u, std::less<llvm::DebugVariable>>>> const&, llvm::DenseMap<llvm::LexicalScope const*, llvm::SmallPtrSet<llvm::MachineBasicBlock*, 4u>, llvm::DenseMapInfo<llvm::LexicalScope const*, void>, llvm::detail::DenseMapPair<llvm::LexicalScope const*, llvm::SmallPtrSet<llvm::MachineBasicBlock*, 4u>>>&, llvm::SmallVector<llvm::SmallVector<std::pair<llvm::DebugVariable, LiveDebugValues::DbgValue>, 8u>, 8u>&, std::unique_ptr<std::unique_ptr<LiveDebugValues::ValueIDNum [], std::default_delete<LiveDebugValues::ValueIDNum []>> [], std::default_delete<std::unique_ptr<LiveDebugValues::ValueIDNum [], std::default_delete<LiveDebugValues::ValueIDNum []>> []>>&, std::unique_ptr<std::unique_ptr<LiveDebugValues::ValueIDNum [], std::default_delete<LiveDebugValues::ValueIDNum []>> [], std::default_delete<std::unique_ptr<LiveDebugValues::ValueIDNum [], std::default_delete<LiveDebugValues::ValueIDNum []>> []>>&, llvm::SmallVectorImpl<LiveDebugValues::VLocTracker>&, llvm::MachineFunction&, llvm::DenseMap<llvm::DebugVariable, unsigned int, llvm::DenseMapInfo<llvm::DebugVariable, void>, llvm::detail::DenseMapPair<llvm::DebugVariable, unsigned int>>&, llvm::TargetPassConfig const&) (/home/nathan/tmp/tmp.gmGKPVYoUk/install/llvm/2cb9e1ac422f46de0ab728c6c9d50ebafbfe372a/bin/clang-16+0x28cc82d) #14 0x000055e800d4a189 LiveDebugValues::InstrRefBasedLDV::ExtendRanges(llvm::MachineFunction&, llvm::MachineDominatorTree*, llvm::TargetPassConfig*, unsigned int, unsigned int) (/home/nathan/tmp/tmp.gmGKPVYoUk/install/llvm/2cb9e1ac422f46de0ab728c6c9d50ebafbfe372a/bin/clang-16+0x28cf189) #15 0x000055e8009b3989 llvm::MachineFunctionPass::runOnFunction(llvm::Function&) (/home/nathan/tmp/tmp.gmGKPVYoUk/install/llvm/2cb9e1ac422f46de0ab728c6c9d50ebafbfe372a/bin/clang-16+0x2538989) #16 0x000055e800e8c5b7 llvm::FPPassManager::runOnFunction(llvm::Function&) (/home/nathan/tmp/tmp.gmGKPVYoUk/install/llvm/2cb9e1ac422f46de0ab728c6c9d50ebafbfe372a/bin/clang-16+0x2a115b7) #17 0x000055e800e94061 llvm::FPPassManager::runOnModule(llvm::Module&) (/home/nathan/tmp/tmp.gmGKPVYoUk/install/llvm/2cb9e1ac422f46de0ab728c6c9d50ebafbfe372a/bin/clang-16+0x2a19061) #18 0x000055e800e8cfc5 llvm::legacy::PassManagerImpl::run(llvm::Module&) (/home/nathan/tmp/tmp.gmGKPVYoUk/install/llvm/2cb9e1ac422f46de0ab728c6c9d50ebafbfe372a/bin/clang-16+0x2a11fc5) #19 0x000055e801dfb46d clang::EmitBackendOutput(clang::DiagnosticsEngine&, clang::HeaderSearchOptions const&, clang::CodeGenOptions const&, clang::TargetOptions const&, clang::LangOptions const&, llvm::StringRef, llvm::Module*, clang::BackendAction, std::unique_ptr<llvm::raw_pwrite_stream, std::default_delete<llvm::raw_pwrite_stream>>) (/home/nathan/tmp/tmp.gmGKPVYoUk/install/llvm/2cb9e1ac422f46de0ab728c6c9d50ebafbfe372a/bin/clang-16+0x398046d) #20 0x000055e8021f8a5e clang::BackendConsumer::HandleTranslationUnit(clang::ASTContext&) CodeGenAction.cpp:0:0 #21 0x000055e802b0447a clang::ParseAST(clang::Sema&, bool, bool) (/home/nathan/tmp/tmp.gmGKPVYoUk/install/llvm/2cb9e1ac422f46de0ab728c6c9d50ebafbfe372a/bin/clang-16+0x468947a) #22 0x000055e80213b3d0 clang::FrontendAction::Execute() (/home/nathan/tmp/tmp.gmGKPVYoUk/install/llvm/2cb9e1ac422f46de0ab728c6c9d50ebafbfe372a/bin/clang-16+0x3cc03d0) #23 0x000055e8020ad53f clang::CompilerInstance::ExecuteAction(clang::FrontendAction&) (/home/nathan/tmp/tmp.gmGKPVYoUk/install/llvm/2cb9e1ac422f46de0ab728c6c9d50ebafbfe372a/bin/clang-16+0x3c3253f) #24 0x000055e8021f1ec2 clang::ExecuteCompilerInvocation(clang::CompilerInstance*) (/home/nathan/tmp/tmp.gmGKPVYoUk/install/llvm/2cb9e1ac422f46de0ab728c6c9d50ebafbfe372a/bin/clang-16+0x3d76ec2) #25 0x000055e80030901a cc1_main(llvm::ArrayRef<char const*>, char const*, void*) (/home/nathan/tmp/tmp.gmGKPVYoUk/install/llvm/2cb9e1ac422f46de0ab728c6c9d50ebafbfe372a/bin/clang-16+0x1e8e01a) #26 0x000055e800306daf ExecuteCC1Tool(llvm::SmallVectorImpl<char const*>&) driver.cpp:0:0 #27 0x000055e801f28b72 void llvm::function_ref<void ()>::callback_fn<clang::driver::CC1Command::Execute(llvm::ArrayRef<llvm::Optional<llvm::StringRef>>, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>*, bool*) const::$_1>(long) Job.cpp:0:0 #28 0x000055e80152b94c llvm::CrashRecoveryContext::RunSafely(llvm::function_ref<void ()>) (/home/nathan/tmp/tmp.gmGKPVYoUk/install/llvm/2cb9e1ac422f46de0ab728c6c9d50ebafbfe372a/bin/clang-16+0x30b094c) #29 0x000055e801f286d0 clang::driver::CC1Command::Execute(llvm::ArrayRef<llvm::Optional<llvm::StringRef>>, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>*, bool*) const (/home/nathan/tmp/tmp.gmGKPVYoUk/install/llvm/2cb9e1ac422f46de0ab728c6c9d50ebafbfe372a/bin/clang-16+0x3aad6d0) #30 0x000055e801ee7d5f clang::driver::Compilation::ExecuteCommand(clang::driver::Command const&, clang::driver::Command const*&, bool) const (/home/nathan/tmp/tmp.gmGKPVYoUk/install/llvm/2cb9e1ac422f46de0ab728c6c9d50ebafbfe372a/bin/clang-16+0x3a6cd5f) #31 0x000055e801ee800e clang::driver::Compilation::ExecuteJobs(clang::driver::JobList const&, llvm::SmallVectorImpl<std::pair<int, clang::driver::Command const*>>&, bool) const (/home/nathan/tmp/tmp.gmGKPVYoUk/install/llvm/2cb9e1ac422f46de0ab728c6c9d50ebafbfe372a/bin/clang-16+0x3a6d00e) #32 0x000055e801f04e80 clang::driver::Driver::ExecuteCompilation(clang::driver::Compilation&, llvm::SmallVectorImpl<std::pair<int, clang::driver::Command const*>>&) (/home/nathan/tmp/tmp.gmGKPVYoUk/install/llvm/2cb9e1ac422f46de0ab728c6c9d50ebafbfe372a/bin/clang-16+0x3a89e80) #33 0x000055e80030647b clang_main(int, char**) (/home/nathan/tmp/tmp.gmGKPVYoUk/install/llvm/2cb9e1ac422f46de0ab728c6c9d50ebafbfe372a/bin/clang-16+0x1e8b47b) #34 0x00007f6e6dc082d0 (/usr/lib/libc.so.6+0x232d0) #35 0x00007f6e6dc0838a __libc_start_main (/usr/lib/libc.so.6+0x2338a) #36 0x000055e8003039e5 _start /build/glibc/src/glibc/csu/../sysdeps/x86_64/start.S:117:0 clang-16: error: clang frontend command failed with exit code 134 (use -v to see invocation) ClangBuiltLinux clang version 16.0.0 (https://github.com/llvm/llvm-project 2cb9e1ac422f46de0ab728c6c9d50ebafbfe372a) Target: x86_64-unknown-linux-gnu Thread model: posix InstalledDir: ... clang-16: note: diagnostic msg: Error generating preprocessed source(s) - no preprocessable inputs.
The parent commit is fine.
Comment Actions
Looks like a fairly trivial fix - the assert in question is erroneous, and will potentially be triggered by any DBG_VALUE_LIST that contains duplicate register entries. I'll make the change, do another round of local testing, and then resubmit the patch.