Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
Nice overall improvements, thanks!
Only one minor suggestion. Do you think an extra test case that verifies something like (x & 0xfff0) >> 17 are properly optimized to 0? Or is such an optimization already covered by all the generic mechanisms so it's not needed here?
Comment Actions
Yes, I have meant to write such a negative test but I find it have already been optimized to 0. So I think we don’t need it here.
Comment Actions
I guessed so. So this is fine, and I've approved. We may wait for a couple of days for others to take a look at this though.