[clang] Dont print implicit forrange initializer

[kadircet]

Summary

Fixes https://github.com/clangd/clangd/issues/1158

[usaxena95]

Thanks!

[CarlosAlbertoEnciso]

@kadircet It seems that your change broke couple of clang tests:

https://lab.llvm.org/buildbot/#/builders/109/builds/40797

[thakis]

Before landing changes, please:

• Run tests
• Look at the result from the presubmit checks

After landing changes, please watch your favorite bot cycle green with it, and pay attention for buildbot email for a while.

[kadircet]

thanks for the revert, you beat me to it.

clang/lib/AST/DeclPrinter.cpp

void DeclPrinter::VisitVarDecl(VarDecl *D) {
 
   printDeclType(T, (isa<ParmVarDecl>(D) && Policy.CleanUglifiedParameters &&
                     D->getIdentifier())
                        ? D->getIdentifier()->deuglifiedName()
                        : D->getName());
   Expr *Init = D->getInit();
   if (!Policy.SuppressInitializers && Init) {
     bool ImplicitInit = false;
-    if (CXXConstructExpr *Construct =
+    if (D->isCXXForRangeDecl()) {
+      // FIXME: We should print the range expression instead.
+      ImplicitInit = true;
+    } else if (CXXConstructExpr *Construct =
                    dyn_cast<CXXConstructExpr>(Init->IgnoreImplicit())) {
       if (D->getInitStyle() == VarDecl::CallInit &&
           !Construct->isListInitialization()) {
         ImplicitInit = Construct->getNumArgs() == 0 ||
                        Construct->getArg(0)->isDefaultArgument();
       }
     }
     if (!ImplicitInit) {
       if ((D->getInitStyle() == VarDecl::CallInit) && !isa<ParenListExpr>(Init))
         Out << "(";
       else if (D->getInitStyle() == VarDecl::CInit) {
         Out << " = ";
       }

clang/unittests/AST/DeclPrinterTest.cpp

 }
 
 TEST(DeclPrinter, VarDeclWithInitializer) {
   ASSERT_TRUE(PrintedDeclCXX17Matches(
       "int a = 0x15;", namedDecl(hasName("a")).bind("id"), "int a = 21"));
   ASSERT_TRUE(PrintedDeclCXX17Matches(
       "int a = 0x15;", namedDecl(hasName("a")).bind("id"), "int a = 0x15",
       [](PrintingPolicy &Policy) { Policy.ConstantsAsWritten = true; }));
+  ASSERT_TRUE(
+      PrintedDeclCXX17Matches("void foo() {int arr[42]; for(int a : arr);}",
+                              namedDecl(hasName("a")).bind("id"), "int a"));
 }