Page MenuHomePhabricator

[CMake][libcxx] Support HWASan
Needs ReviewPublic

Authored by phosek on Jun 12 2022, 5:32 PM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Summary

This is analogous to ASan.

Diff Detail

Unit TestsFailed

TimeTest
4,110 mslibcxx CI No locale > llvm-libc++-shared-cfg-in.libcxx::modules_include.sh.cpp
Script: -- : 'RUN: at line 46'; /usr/bin/c++ /home/libcxx-builder/.buildkite-agent/builds/3281ffea39a5-1/llvm-project/libcxx-ci/libcxx/test/libcxx/modules_include.sh.cpp --target=x86_64-unknown-linux-gnu -nostdinc++ -I /home/libcxx-builder/.buildkite-agent/builds/3281ffea39a5-1/llvm-project/libcxx-ci/build/generic-no-localization/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/3281ffea39a5-1/llvm-project/libcxx-ci/build/generic-no-localization/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/3281ffea39a5-1/llvm-project/libcxx-ci/libcxx/test/support -std=c++2b -Werror -Wall -Wextra -Wshadow -Wundef -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-noexcept-type -Wno-atomic-alignment -Wno-user-defined-literals -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -D_LIBCPP_DISABLE_AVAILABILITY -fcoroutines-ts -Werror=thread-safety -Wuser-defined-warnings -fmodules -fcxx-modules -fsyntax-only -DTEST_0

Event Timeline

phosek created this revision.Jun 12 2022, 5:32 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 12 2022, 5:32 PM
Herald added a subscriber: mgorny. · View Herald Transcript
phosek requested review of this revision.Jun 12 2022, 5:32 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 12 2022, 5:32 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne requested changes to this revision.Jun 13 2022, 8:16 AM

I assume we should also add the ability to test libc++ that way? If so, let's add it (libcxx/utils/libcxx/test/params.py:129). How is HWAddress different from Address? Is it worth adding a CI job?

This revision now requires changes to proceed.Jun 13 2022, 8:16 AM
phosek updated this revision to Diff 436499.Jun 13 2022, 11:52 AM

I assume we should also add the ability to test libc++ that way? If so, let's add it (libcxx/utils/libcxx/test/params.py:129).

Done.

How is HWAddress different from Address? Is it worth adding a CI job?

It uses TBI on AArch64 to reduce performance overhead. Do we have AArch64 machines in CI?