This is an archive of the discontinued LLVM Phabricator instance.

[CMake][libcxx] Support HWASan
Needs RevisionPublic

Authored by phosek on Jun 12 2022, 5:32 PM.

Details

Reviewers
ldionne
Mordante
Group Reviewers
Restricted Project
Summary

This is analogous to ASan.

Diff Detail

Event Timeline

phosek created this revision.Jun 12 2022, 5:32 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 12 2022, 5:32 PM
Herald added a subscriber: mgorny. · View Herald Transcript
phosek requested review of this revision.Jun 12 2022, 5:32 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 12 2022, 5:32 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne requested changes to this revision.Jun 13 2022, 8:16 AM

I assume we should also add the ability to test libc++ that way? If so, let's add it (libcxx/utils/libcxx/test/params.py:129). How is HWAddress different from Address? Is it worth adding a CI job?

This revision now requires changes to proceed.Jun 13 2022, 8:16 AM
phosek updated this revision to Diff 436499.Jun 13 2022, 11:52 AM

I assume we should also add the ability to test libc++ that way? If so, let's add it (libcxx/utils/libcxx/test/params.py:129).

Done.

How is HWAddress different from Address? Is it worth adding a CI job?

It uses TBI on AArch64 to reduce performance overhead. Do we have AArch64 machines in CI?

Mordante requested changes to this revision.Sep 4 2023, 9:39 AM
Mordante added a subscriber: Mordante.

Parts of this work seem the have landed in https://reviews.llvm.org/rG18014fe0a9bf41775e377db7a4214a159f79f257 can you rebase this patch and see whether there is anything left?

This revision now requires changes to proceed.Sep 4 2023, 9:39 AM