[clang-cl] Accept /FA[c][s][u], but ignore the arguments

[steplong]

Summary

Previously, /FAsc would emit a warning. Now, it will just do what /FA does.

https://docs.microsoft.com/en-us/cpp/build/reference/fa-fa-listing-file?view=msvc-170

[steplong]

I'm not sure which test file to modify and how to test this. I do see it generating the .asm file now when I pass /FAsc, not the .codd file though since we are ignoring the c argument.

[hans]

Previously, /FAsc would emit a warning. Now, it will just do what /FA does.

I suppose we could still warn that the 's' and 'c' parts are ignored.. though I suppose that becomes evident from the output file..

If we're going to treat them the same, how about just making the _SLASH_FA option a CLJoined and dropping _SLASH_FA_joined?

I'm not sure which test file to modify and how to test this. I do see it generating the .asm file now when I pass /FAsc, not the .codd file though since we are ignoring the c argument.

There are some /FA tests in clang/test/Driver/cl-options.c and clang/test/Driver/cl-outputs.c.

[steplong]

• Removed SLASH_FA_joined and made SLASH_FA a CLJoined
• Add some /FAcsu tests. Just copies of /FA tests, but passing /FAcsu

[hans]

lgtm

clang/lib/Driver/Driver.cpp

const JobAction *getPrevDependentAction(const ActionList &Inputs,
     return dyn_cast<JobAction>(CurAction);
   }
 
   /// Return true if an assemble action can be collapsed.
   bool canCollapseAssembleAction() const {
     return TC.useIntegratedAs() && !SaveTemps &&
            !C.getArgs().hasArg(options::OPT_via_file_asm) &&
            !C.getArgs().hasArg(options::OPT__SLASH_FA) &&
-           !C.getArgs().hasArg(options::OPT__SLASH_Fa);
+           !C.getArgs().hasArg(options::OPT__SLASH_Fa) &&
+           !C.getArgs().hasArg(options::OPT__SLASH_FA_joined);
   }
 
   /// Return true if a preprocessor action can be collapsed.
   bool canCollapsePreprocessorAction() const {
     return !C.getArgs().hasArg(options::OPT_no_integrated_cpp) &&
            !C.getArgs().hasArg(options::OPT_traditional_cpp) && !SaveTemps &&
            !C.getArgs().hasArg(options::OPT_rewrite_objc);
   }
const char *Driver::GetNamedOutputPath(Compilation &C, const JobAction &JA,
   if (JA.getType() == types::TY_ModuleFile &&
       C.getArgs().getLastArg(options::OPT_module_file_info)) {
     return "-";
   }
 
   // Is this the assembly listing for /FA?
   if (JA.getType() == types::TY_PP_Asm &&
       (C.getArgs().hasArg(options::OPT__SLASH_FA) ||
-       C.getArgs().hasArg(options::OPT__SLASH_Fa))) {
+       C.getArgs().hasArg(options::OPT__SLASH_Fa) ||
+       C.getArgs().hasArg(options::OPT__SLASH_FA_joined))) {
     // Use /Fa and the input filename to determine the asm file name.
     StringRef BaseName = llvm::sys::path::filename(BaseInput);
     StringRef FaValue = C.getArgs().getLastArgValue(options::OPT__SLASH_Fa);
     return C.addResultFile(
         MakeCLOutputFilename(C.getArgs(), FaValue, BaseName, JA.getType()),
         &JA);
   }