Page MenuHomePhabricator

[MLIR][Shape] Generalize `shape.concat` to extent tensors
ClosedPublic

Authored by qingyunqu on Jun 8 2022, 10:12 AM.

Details

Summary

The operation shape.concat was used for type shape only.
We now enable it for extent tensors.

Diff Detail

Event Timeline

qingyunqu created this revision.Jun 8 2022, 10:12 AM
qingyunqu requested review of this revision.Jun 8 2022, 10:12 AM
qingyunqu edited reviewers, added: herhut; removed: joker-eph-DISABLED. qingyunqu removed 1 blocking reviewer(s): jpienaar.Jun 8 2022, 10:35 AM
jpienaar accepted this revision.Jun 8 2022, 10:52 AM

LG, thanks

This revision is now accepted and ready to land.Jun 8 2022, 10:52 AM

Do you have commit access or do you need someone to push this for you?

LG, thanks

Should I change the $lhs and $rhs to Variadic<Shape_ShapeOrExtentTensorType>? @jpienaar

Do you have commit access or do you need someone to push this for you?

I don't really get the point. What should I do between these two methods.

Do you have commit access or do you need someone to push this for you?

I don't really get the point. What should I do between these two methods.

Regular contributors have direct write access to the repository and take care themselves to git push their changes to the main branch. On the other hand new contributors don't have write access and rely on the reviewer to push the change for them after approving.

Do you have commit access or do you need someone to push this for you?

I don't really get the point. What should I do between these two methods.

Regular contributors have direct write access to the repository and take care themselves to git push their changes to the main branch. On the other hand new contributors don't have write access and rely on the reviewer to push the change for them after approving.

I think I'm the new contributor.

LG, thanks

Should I change the $lhs and $rhs to Variadic<Shape_ShapeOrExtentTensorType>? @jpienaar

No, these are currently intended to be explicit and fixed.

If you have a shape function with a lot concats where this would simplify things, I'd be interested to know about

This revision was automatically updated to reflect the committed changes.