@bkramer Could you please help to merge this PR? I don't have the merge permission. Thanks!

In D131480#3712424, @jpienaar wrote:

In D131480#3711409, @qingyunqu wrote:

In D131480#3709709, @jpienaar wrote:

Matches the comment and what was there before (https://github.com/llvm/llvm-project/blob/2c384c37727660f11f63fda461210d1a6f5d2afe/mlir/lib/Transforms/SCCP.cpp#L84). Seems SCCP has some missing test coverage.

Do you have a test case that triggers for this one?

I trigger this when working on mhlo.reduce op. But I think I could create a test like https://reviews.llvm.org/D130453

Thanks that would be great.

In D131480#3709709, @jpienaar wrote:

Matches the comment and what was there before (https://github.com/llvm/llvm-project/blob/2c384c37727660f11f63fda461210d1a6f5d2afe/mlir/lib/Transforms/SCCP.cpp#L84). Seems SCCP has some missing test coverage.

Do you have a test case that triggers for this one?

Also remove Linalg pass declaration which is not cleaned.

In D127321#3568353, @mehdi_amini wrote:

In D127321#3567648, @qingyunqu wrote:

In D127321#3567615, @mehdi_amini wrote:

Do you have commit access or do you need someone to push this for you?

I don't really get the point. What should I do between these two methods.

Regular contributors have direct write access to the repository and take care themselves to git push their changes to the main branch. On the other hand new contributors don't have write access and rely on the reviewer to push the change for them after approving.

In D127321#3567615, @mehdi_amini wrote:

Do you have commit access or do you need someone to push this for you?

In D127321#3567440, @jpienaar wrote:

LG, thanks