This is an archive of the discontinued LLVM Phabricator instance.

Differential D126923

llvm: cmake: set CMP0114 to OLD to avoid warning
ClosedPublic

Authored by nickdesaulniers on Jun 2 2022, 2:40 PM.

Details

Reviewers
phosek
penzn
Commits
rG1a216dc8910f: llvm: cmake: set CMP0114 to OLD to avoid warning
Summary

Building with cmake 3.23.2+ produces warnings when using
LLVM_ENABLE_RUNTIMES. Set this policy to the existing behavior for now
to silence the warnings.

Fixes: https://github.com/llvm/llvm-project/issues/50122
Fixes: https://github.com/llvm/llvm-project/issues/54944

Diff Detail

Event Timeline

nickdesaulniers created this revision.Jun 2 2022, 2:40 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 2 2022, 2:40 PM
Herald added a subscriber: mgorny. · View Herald Transcript
nickdesaulniers requested review of this revision.Jun 2 2022, 2:40 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 2 2022, 2:40 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
penzn accepted this revision.Jun 2 2022, 2:47 PM
penzn added a subscriber: penzn.

I am personally building with this change already, for extra peace of mind :)

This revision is now accepted and ready to land.Jun 2 2022, 2:47 PM
phosek accepted this revision.Jun 2 2022, 2:55 PM

LGTM

Harbormaster completed remote builds in B167622: Diff 433891.Jun 2 2022, 4:09 PM
This revision was landed with ongoing or failed builds.Jun 3 2022, 9:45 AM
Closed by commit rG1a216dc8910f: llvm: cmake: set CMP0114 to OLD to avoid warning (authored by nickdesaulniers). · Explain Why
This revision was automatically updated to reflect the committed changes.
nickdesaulniers added a commit: rG1a216dc8910f: llvm: cmake: set CMP0114 to OLD to avoid warning.

Revision Contents

PathSize
llvm/
5 lines

Diff 434049

llvm/CMakeLists.txt

# See docs/CMake.html for instructions about how to build LLVM with CMake. # See docs/CMake.html for instructions about how to build LLVM with CMake.
cmake_minimum_required(VERSION 3.13.4) cmake_minimum_required(VERSION 3.13.4)
# CMP0114: ExternalProject step targets fully adopt their steps.
# New in CMake 3.19: https://cmake.org/cmake/help/latest/policy/CMP0114.html
if(POLICY CMP0114)
cmake_policy(SET CMP0114 OLD)
endif()
# CMP0116: Ninja generators transform `DEPFILE`s from `add_custom_command()` # CMP0116: Ninja generators transform `DEPFILE`s from `add_custom_command()`
# New in CMake 3.20. https://cmake.org/cmake/help/latest/policy/CMP0116.html # New in CMake 3.20. https://cmake.org/cmake/help/latest/policy/CMP0116.html
if(POLICY CMP0116) if(POLICY CMP0116)
cmake_policy(SET CMP0116 OLD) cmake_policy(SET CMP0116 OLD)
endif() endif()
set(CMAKE_BUILD_WITH_INSTALL_NAME_DIR ON) set(CMAKE_BUILD_WITH_INSTALL_NAME_DIR ON)
▲ Show 20 Lines • Show All 1,263 Lines • Show Last 20 Lines