This is an archive of the discontinued LLVM Phabricator instance.

[lld][WebAssemlby] Check for command line flags with missing arguments
ClosedPublic

Authored by sbc100 on May 26 2022, 1:14 PM.

Details

Summary

I'm really not sure how this was overlooked when we first ported lld
to Wasm. The upstream code in the ELF backend has these two lines but
for some reason they never make it into the Wasm version.

Diff Detail

Event Timeline

sbc100 created this revision.May 26 2022, 1:14 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 26 2022, 1:14 PM
sbc100 requested review of this revision.May 26 2022, 1:14 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 26 2022, 1:14 PM
dschuff added inline comments.May 26 2022, 1:21 PM
lld/wasm/Driver.cpp
187

this bit looks separate from the 'reproduce' parts, and the commit message only indicates about this. were they intended to be separate CLs?

sbc100 updated this revision to Diff 432372.May 26 2022, 1:23 PM
  • split
lld/wasm/Driver.cpp
187

Sorry, yes, two changes in one.. split them up now.

dschuff accepted this revision.May 26 2022, 1:29 PM
This revision is now accepted and ready to land.May 26 2022, 1:29 PM
This revision was landed with ongoing or failed builds.May 26 2022, 1:35 PM
This revision was automatically updated to reflect the committed changes.