This is an archive of the discontinued LLVM Phabricator instance.

Differential D126418

[scudo] Link against libatomic on all MIPS targets
ClosedPublic

Authored by glaubitz on May 25 2022, 1:39 PM.

Details

Reviewers
atanasyan
MaskRay
wzssyqa
Commits
rGa1ec3c5a8885: [scudo] Link against libatomic on all MIPS targets

Diff Detail

Event Timeline

glaubitz created this revision.May 25 2022, 1:39 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 25 2022, 1:39 PM
Herald added subscribers: StephenFan, cryptoad, arichardson and 2 others. · View Herald Transcript
glaubitz requested review of this revision.May 25 2022, 1:39 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 25 2022, 1:39 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
glaubitz mentioned this in D126391: MIPS: compiler-rt/scudo requires atomic.May 25 2022, 1:40 PM
MaskRay accepted this revision.May 25 2022, 2:00 PM
This revision is now accepted and ready to land.May 25 2022, 2:00 PM
Harbormaster completed remote builds in B166358: Diff 432111.May 25 2022, 2:30 PM
Closed by commit rGa1ec3c5a8885: [scudo] Link against libatomic on all MIPS targets (authored by glaubitz, committed by MaskRay). · Explain WhyMay 26 2022, 12:00 AM
This revision was automatically updated to reflect the committed changes.
MaskRay added a commit: rGa1ec3c5a8885: [scudo] Link against libatomic on all MIPS targets.

Revision Contents

PathSize
compiler-rt/
lib/
scudo/
standalone/
4 lines

Diff 432204

compiler-rt/lib/scudo/standalone/CMakeLists.txt

Show First 20 Lines • Show All 134 Lines • ▼ Show 20 Lines
endif() endif()
set(SCUDO_LINK_LIBS) set(SCUDO_LINK_LIBS)
append_list_if(COMPILER_RT_HAS_LIBPTHREAD -pthread SCUDO_LINK_FLAGS) append_list_if(COMPILER_RT_HAS_LIBPTHREAD -pthread SCUDO_LINK_FLAGS)
append_list_if(FUCHSIA zircon SCUDO_LINK_LIBS) append_list_if(FUCHSIA zircon SCUDO_LINK_LIBS)
if(COMPILER_RT_DEFAULT_TARGET_ARCH MATCHES "mips|mips64|mipsel|mips64el")
list(APPEND SCUDO_LINK_LIBS atomic)
endif()
if(COMPILER_RT_HAS_SCUDO_STANDALONE) if(COMPILER_RT_HAS_SCUDO_STANDALONE)
add_compiler_rt_object_libraries(RTScudoStandalone add_compiler_rt_object_libraries(RTScudoStandalone
ARCHS ${SCUDO_STANDALONE_SUPPORTED_ARCH} ARCHS ${SCUDO_STANDALONE_SUPPORTED_ARCH}
SOURCES ${SCUDO_SOURCES} SOURCES ${SCUDO_SOURCES}
ADDITIONAL_HEADERS ${SCUDO_HEADERS} ADDITIONAL_HEADERS ${SCUDO_HEADERS}
CFLAGS ${SCUDO_CFLAGS}) CFLAGS ${SCUDO_CFLAGS})
add_compiler_rt_object_libraries(RTScudoStandaloneCWrappers add_compiler_rt_object_libraries(RTScudoStandaloneCWrappers
ARCHS ${SCUDO_STANDALONE_SUPPORTED_ARCH} ARCHS ${SCUDO_STANDALONE_SUPPORTED_ARCH}
▲ Show 20 Lines • Show All 41 Lines • Show Last 20 Lines