This is an archive of the discontinued LLVM Phabricator instance.

MIPS: compiler-rt/scudo requires atomic
AbandonedPublic

Authored by wzssyqa on May 25 2022, 9:39 AM.

Details

Reviewers
atanasyan
MaskRay
Summary

On mips, atomic is needed for SCUDO_LINK_LIBS.

Diff Detail

Event Timeline

wzssyqa created this revision.May 25 2022, 9:39 AM
wzssyqa requested review of this revision.May 25 2022, 9:39 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 25 2022, 9:39 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript

The target platform instead of the host platform should be tested. We may need something like COMPILER_RT_DEFAULT_TARGET_ARCH.

I have created a new revision which works fine for me on mips64el, see: https://reviews.llvm.org/D126418

Let me know whether this is acceptable otherwise I'll close it again. I just want to speed up the review process since the change is trivial enough anyway.

MaskRay requested changes to this revision.May 25 2022, 11:58 PM
This revision now requires changes to proceed.May 25 2022, 11:58 PM
wzssyqa abandoned this revision.Oct 9 2022, 8:24 PM

another patches has been accepted.