This is an archive of the discontinued LLVM Phabricator instance.

[analyzer] SATest: Weaken assumption about HTML files
ClosedPublic

Authored by mantognini on May 23 2022, 5:00 AM.

Details

Summary

Instead of assuming there is an HTML file for each diagnostics, consider
the HTML files only when they exist, individually of each other.

After generating the reference data, running

python /scripts/SATest.py build --projects simbody

was resulting in this error:

  File "/scripts/CmpRuns.py", line 250, in read_single_file
    assert len(d['HTMLDiagnostics_files']) == 1
KeyError: 'HTMLDiagnostics_files'

Diff Detail

Event Timeline

mantognini created this revision.May 23 2022, 5:00 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 23 2022, 5:00 AM
mantognini published this revision for review.May 24 2022, 12:56 AM
mantognini added reviewers: vsavchenko, steakhal.

This patch relates to my previous comment: https://reviews.llvm.org/D124621#3485799

Herald added a project: Restricted Project. · View Herald TranscriptMay 24 2022, 12:56 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
steakhal accepted this revision.May 24 2022, 2:01 AM

I'm not using this script file, so I'm not gonna be too picky about this.
However, I would be more confident landing changes if we had tests exercising the changed behavior.
If you plan to land more changes to this file, consider adding some tests.

This revision is now accepted and ready to land.May 24 2022, 2:01 AM

I'm not using this script file, so I'm not gonna be too picky about this.
However, I would be more confident landing changes if we had tests exercising the changed behavior.
If you plan to land more changes to this file, consider adding some tests.

I agree tests would be good, but I'm not sure where to start. To clarify, that is also the only change I've got to this file and I don't plan further change in the near future.

This revision was automatically updated to reflect the committed changes.