This is an archive of the discontinued LLVM Phabricator instance.

Differential D126070

[AMDGPU][MC][GFX940] Disable v_mac_f32_dpp
ClosedPublic

Authored by dp on May 20 2022, 7:43 AM.

Details

Reviewers
rampitec
foad
Commits
rG818cc9b285e8: [AMDGPU][MC][GFX940] Disable v_mac_f32_dpp
Summary

See bug 55612 for issue description.

Diff Detail

Unit TestsFailed

TimeTest
60,090 msx64 debian > AddressSanitizer-x86_64-linux-dynamic.TestCases::scariness_score_test.cpp
60,140 msx64 debian > AddressSanitizer-x86_64-linux.TestCases::scariness_score_test.cpp
60,080 msx64 debian > MLIR.Examples/standalone::test.toy
60,050 msx64 debian > ThreadSanitizer-x86_64.ThreadSanitizer-x86_64::restore_stack.cpp
2,020 msx64 debian > libFuzzer.libFuzzer::merge_two_step.test

Event Timeline

dp created this revision.May 20 2022, 7:43 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 20 2022, 7:43 AM
Herald added subscribers: kosarev, hsmhsm, kerbowa and 8 others. · View Herald Transcript
dp requested review of this revision.May 20 2022, 7:43 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 20 2022, 7:43 AM
Herald added subscribers: llvm-commits, wdng. · View Herald Transcript
Harbormaster completed remote builds in B165522: Diff 430964.May 20 2022, 8:48 AM
rampitec accepted this revision.May 20 2022, 8:55 AM
This revision is now accepted and ready to land.May 20 2022, 8:55 AM
This revision was landed with ongoing or failed builds.May 23 2022, 5:50 AM
Closed by commit rG818cc9b285e8: [AMDGPU][MC][GFX940] Disable v_mac_f32_dpp (authored by dp). · Explain Why
This revision was automatically updated to reflect the committed changes.
dp added a commit: rG818cc9b285e8: [AMDGPU][MC][GFX940] Disable v_mac_f32_dpp.

Revision Contents

PathSize
llvm/
lib/
Target/
AMDGPU/
1 line
test/
MC/
AMDGPU/
15 lines

Diff 430964

llvm/lib/Target/AMDGPU/VOPInstructions.td

Context not available.
let isConvergent = ps.isConvergent; let isConvergent = ps.isConvergent;
let SubtargetPredicate = ps.SubtargetPredicate; let SubtargetPredicate = ps.SubtargetPredicate;
let AssemblerPredicate = ps.AssemblerPredicate; let AssemblerPredicate = ps.AssemblerPredicate;
let OtherPredicates = ps.OtherPredicates;
let AsmMatchConverter = ps.AsmMatchConverter; let AsmMatchConverter = ps.AsmMatchConverter;
let AsmVariantName = ps.AsmVariantName; let AsmVariantName = ps.AsmVariantName;
let UseNamedOperandTable = ps.UseNamedOperandTable; let UseNamedOperandTable = ps.UseNamedOperandTable;
Context not available.

llvm/test/MC/AMDGPU/gfx940_err.s

// RUN: not llvm-mc -arch=amdgcn -mcpu=gfx940 %s 2>&1 | FileCheck --check-prefix=GFX940 --implicit-check-not=error: %s // RUN: not llvm-mc -arch=amdgcn -mcpu=gfx940 %s 2>&1 | FileCheck --check-prefix=GFX940 --implicit-check-not=error: %s
v_mac_f32 v0, v1, v2 v_mac_f32 v0, v1, v2
// FIXME: error message is incorrect // GFX940: error: instruction not supported on this GPU
// GFX940: error: operands are not valid for this GPU or mode
v_mac_f32_e64 v5, v1, v2
// GFX940: error: instruction not supported on this GPU
v_mac_f32_dpp v5, v1, v2 quad_perm:[0,1,2,3] row_mask:0xf bank_mask:0xf
// GFX940: error: instruction not supported on this GPU
v_mac_f32_dpp v5, v1, v2 dpp8:[7,6,5,4,3,2,1,0]
// GFX940: error: instruction not supported on this GPU
v_mac_f32_sdwa v5, v1, v2 dst_sel:DWORD dst_unused:UNUSED_PRESERVE src0_sel:DWORD src1_sel:DWORD
// GFX940: error: instruction not supported on this GPU
v_mad_f32 v0, v1, v2, v3 v_mad_f32 v0, v1, v2, v3
// GFX940: error: instruction not supported on this GPU // GFX940: error: instruction not supported on this GPU