Page MenuHomePhabricator

[X86] Add tests for FREM
ClosedPublic

Authored by n-omer on May 20 2022, 2:34 AM.

Details

Summary

Introduces basic test coverage for frem on x86.

Split off from https://reviews.llvm.org/D125988

Diff Detail

Event Timeline

n-omer created this revision.May 20 2022, 2:34 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 20 2022, 2:34 AM
n-omer requested review of this revision.May 20 2022, 2:34 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 20 2022, 2:34 AM
RKSimon accepted this revision.May 20 2022, 2:42 AM

LGTM with one minor - nice to have some actual test coverage!

llvm/test/CodeGen/X86/frem-libcall.ll
5

Add a FIXME as this is currently broken

This revision is now accepted and ready to land.May 20 2022, 2:42 AM
n-omer updated this revision to Diff 430928.May 20 2022, 2:44 AM

Address review comments.

This revision was landed with ongoing or failed builds.May 20 2022, 8:28 AM
Closed by commit rGaed49eac87b8: [X86] Add tests for FREM (authored by n-omer, committed by jmorse). · Explain Why
This revision was automatically updated to reflect the committed changes.