Page MenuHomePhabricator

n-omer (Nabeel Omer)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 30 2020, 6:49 AM (90 w, 4 d)

Recent Activity

Fri, Jun 24

n-omer committed rG0d4179433576: [SLP] Add cost model for `llvm.powi.*` intrinsics (REAPPLIED) (authored by n-omer).
[SLP] Add cost model for `llvm.powi.*` intrinsics (REAPPLIED)
Fri, Jun 24, 3:24 AM · Restricted Project, Restricted Project

Thu, Jun 23

n-omer updated the diff for D128172: [SLP] Add cost model for `llvm.powi.*` intrinsics.

Fix cost model.

Thu, Jun 23, 8:11 AM · Restricted Project, Restricted Project
n-omer updated the diff for D128172: [SLP] Add cost model for `llvm.powi.*` intrinsics.

Improve the cost computation and update tests.

Thu, Jun 23, 3:55 AM · Restricted Project, Restricted Project

Wed, Jun 22

n-omer updated the diff for D128172: [SLP] Add cost model for `llvm.powi.*` intrinsics.

Modify AArch64 and RISCV tests.

Wed, Jun 22, 9:15 AM · Restricted Project, Restricted Project
n-omer updated the diff for D128172: [SLP] Add cost model for `llvm.powi.*` intrinsics.

Add context to diff.

Wed, Jun 22, 3:51 AM · Restricted Project, Restricted Project
n-omer updated the diff for D128172: [SLP] Add cost model for `llvm.powi.*` intrinsics.

Update failing cost model tests.

Wed, Jun 22, 2:54 AM · Restricted Project, Restricted Project

Tue, Jun 21

n-omer added a comment to D128172: [SLP] Add cost model for `llvm.powi.*` intrinsics.

Reverted due to test failures, investigating further.

Tue, Jun 21, 8:07 AM · Restricted Project, Restricted Project
n-omer added a reverting change for rGe6ccb57bb3f6: [SLP] Add cost model for `llvm.powi.*` intrinsics: rG4c5f10aeebd7: Revert rGe6ccb57bb3f6b761f2310e97fd6ca99eff42f73e "[SLP] Add cost model for….
Tue, Jun 21, 8:06 AM · Restricted Project, Restricted Project
n-omer committed rG4c5f10aeebd7: Revert rGe6ccb57bb3f6b761f2310e97fd6ca99eff42f73e "[SLP] Add cost model for… (authored by n-omer).
Revert rGe6ccb57bb3f6b761f2310e97fd6ca99eff42f73e "[SLP] Add cost model for…
Tue, Jun 21, 8:06 AM · Restricted Project, Restricted Project
n-omer added a reverting change for D128172: [SLP] Add cost model for `llvm.powi.*` intrinsics: rG4c5f10aeebd7: Revert rGe6ccb57bb3f6b761f2310e97fd6ca99eff42f73e "[SLP] Add cost model for….
Tue, Jun 21, 8:06 AM · Restricted Project, Restricted Project
n-omer committed rGe6ccb57bb3f6: [SLP] Add cost model for `llvm.powi.*` intrinsics (authored by n-omer).
[SLP] Add cost model for `llvm.powi.*` intrinsics
Tue, Jun 21, 7:41 AM · Restricted Project, Restricted Project
n-omer closed D128172: [SLP] Add cost model for `llvm.powi.*` intrinsics.
Tue, Jun 21, 7:41 AM · Restricted Project, Restricted Project
n-omer updated the diff for D128172: [SLP] Add cost model for `llvm.powi.*` intrinsics.

Remove unused included file.

Tue, Jun 21, 2:29 AM · Restricted Project, Restricted Project

Mon, Jun 20

n-omer updated the diff for D128172: [SLP] Add cost model for `llvm.powi.*` intrinsics.

Add context to diff.

Mon, Jun 20, 6:50 AM · Restricted Project, Restricted Project
n-omer updated the diff for D128172: [SLP] Add cost model for `llvm.powi.*` intrinsics.

Rebase patch and address review comments.

Mon, Jun 20, 6:49 AM · Restricted Project, Restricted Project
n-omer committed rGcd8870e85082: [SLP] Add a test for llvm.powi.* (authored by n-omer).
[SLP] Add a test for llvm.powi.*
Mon, Jun 20, 5:42 AM · Restricted Project, Restricted Project
n-omer closed D128178: [SLP] Add a test for llvm.powi.* intrinsics.
Mon, Jun 20, 5:42 AM · Restricted Project, Restricted Project
n-omer updated the diff for D128178: [SLP] Add a test for llvm.powi.* intrinsics.

Remove unnecessary attribute from test.

Mon, Jun 20, 3:37 AM · Restricted Project, Restricted Project
n-omer added a comment to D128172: [SLP] Add cost model for `llvm.powi.*` intrinsics.

@RKSimon I've created https://reviews.llvm.org/D128178 for the test.

Mon, Jun 20, 3:29 AM · Restricted Project, Restricted Project
n-omer requested review of D128178: [SLP] Add a test for llvm.powi.* intrinsics.
Mon, Jun 20, 3:28 AM · Restricted Project, Restricted Project
n-omer retitled D128172: [SLP] Add cost model for `llvm.powi.*` intrinsics from [SLP] Add cost models for llvm.powi.* intrinsics to [SLP] Add cost model for `llvm.powi.*` intrinsics.
Mon, Jun 20, 3:00 AM · Restricted Project, Restricted Project
n-omer updated the diff for D128172: [SLP] Add cost model for `llvm.powi.*` intrinsics.

Add context to diff.

Mon, Jun 20, 2:58 AM · Restricted Project, Restricted Project
n-omer requested review of D128172: [SLP] Add cost model for `llvm.powi.*` intrinsics.
Mon, Jun 20, 2:52 AM · Restricted Project, Restricted Project

Tue, Jun 14

n-omer updated the diff for D127492: [X86][SLP] Basic test coverage for llvm.powi.

Update RUN lines to fix failing builds and add new variable argument test to SLP.

Tue, Jun 14, 5:42 AM · Restricted Project, Restricted Project
n-omer updated the diff for D127492: [X86][SLP] Basic test coverage for llvm.powi.

Replace undef with poison.

Tue, Jun 14, 2:37 AM · Restricted Project, Restricted Project

Mon, Jun 13

n-omer updated the diff for D127492: [X86][SLP] Basic test coverage for llvm.powi.

Address review comments.

Mon, Jun 13, 2:41 AM · Restricted Project, Restricted Project

Fri, Jun 10

n-omer requested review of D127492: [X86][SLP] Basic test coverage for llvm.powi.
Fri, Jun 10, 5:55 AM · Restricted Project, Restricted Project

May 24 2022

n-omer updated the diff for D125988: [x86][SelectionDAG] Unroll vectorized FREM instructions which will be lowered to libcalls.

Update diff based on reviewer's comments.

May 24 2022, 1:49 AM · Restricted Project, Restricted Project

May 23 2022

n-omer updated the diff for D125988: [x86][SelectionDAG] Unroll vectorized FREM instructions which will be lowered to libcalls.

Update diff based on reviewer's comments.

May 23 2022, 10:01 AM · Restricted Project, Restricted Project
n-omer updated the diff for D125988: [x86][SelectionDAG] Unroll vectorized FREM instructions which will be lowered to libcalls.

Remove FIXME from test.

May 23 2022, 7:36 AM · Restricted Project, Restricted Project
n-omer updated the summary of D125988: [x86][SelectionDAG] Unroll vectorized FREM instructions which will be lowered to libcalls.
May 23 2022, 7:33 AM · Restricted Project, Restricted Project
n-omer updated the diff for D125988: [x86][SelectionDAG] Unroll vectorized FREM instructions which will be lowered to libcalls.

Add context to diff.

May 23 2022, 7:31 AM · Restricted Project, Restricted Project
n-omer updated the diff for D125988: [x86][SelectionDAG] Unroll vectorized FREM instructions which will be lowered to libcalls.

Update diff based on review comments.

May 23 2022, 7:27 AM · Restricted Project, Restricted Project

May 20 2022

n-omer updated the diff for D125988: [x86][SelectionDAG] Unroll vectorized FREM instructions which will be lowered to libcalls.

Updating the diff for completeness because D126055. Still looking into the reviewers comments.

May 20 2022, 9:34 AM · Restricted Project, Restricted Project
n-omer updated the diff for D126055: [X86] Add tests for FREM.

Address review comments.

May 20 2022, 2:45 AM · Restricted Project, Restricted Project
n-omer added a comment to D125988: [x86][SelectionDAG] Unroll vectorized FREM instructions which will be lowered to libcalls.

Hi @RKSimon, I've updated the tests for the current trunk and split them off into https://reviews.llvm.org/D126055.

May 20 2022, 2:36 AM · Restricted Project, Restricted Project
n-omer requested review of D126055: [X86] Add tests for FREM.
May 20 2022, 2:34 AM · Restricted Project, Restricted Project

May 19 2022

n-omer requested review of D125988: [x86][SelectionDAG] Unroll vectorized FREM instructions which will be lowered to libcalls.
May 19 2022, 9:33 AM · Restricted Project, Restricted Project

Jun 4 2021

n-omer updated n-omer.
Jun 4 2021, 2:37 AM
n-omer updated n-omer.
Jun 4 2021, 2:36 AM

Dec 17 2020

n-omer updated the diff for D92576: Remove insertDebugValuesForPHIs() from LCSSA to prevent assignments from being reordered.

Resolve another merge conflict Transforms/LoopIdiom/X86/left-shift-until-bittest.ll.

Dec 17 2020, 7:25 AM · Restricted Project, debug-info

Dec 16 2020

n-omer updated the diff for D92576: Remove insertDebugValuesForPHIs() from LCSSA to prevent assignments from being reordered.

Transforms/LoopIdiom/X86/left-shift-until-bittest.ll test was recently added in this commit. The test in its current form relies on LCSSA's current behaviour. I have updated the patch to remove that reliance.

Dec 16 2020, 8:01 AM · Restricted Project, debug-info

Dec 14 2020

n-omer added a comment to D92576: Remove insertDebugValuesForPHIs() from LCSSA to prevent assignments from being reordered.

LGTM, although couldn't you also just swap the basictest.ll DEBUGIFY-NEXT to be a DEBUGIFY-NOT: call void @llvm.dbg.value and not add the extra test.

(Nabeel and I share a corporate overloard, we should leave this a little more time in case anyone else wants to chip in).

Dec 14 2020, 6:43 AM · Restricted Project, debug-info

Dec 7 2020

n-omer updated the summary of D92576: Remove insertDebugValuesForPHIs() from LCSSA to prevent assignments from being reordered.
Dec 7 2020, 4:21 AM · Restricted Project, debug-info

Dec 3 2020

n-omer updated the diff for D92576: Remove insertDebugValuesForPHIs() from LCSSA to prevent assignments from being reordered.

Added context to diff.

Dec 3 2020, 7:35 AM · Restricted Project, debug-info
n-omer requested review of D92576: Remove insertDebugValuesForPHIs() from LCSSA to prevent assignments from being reordered.
Dec 3 2020, 7:17 AM · Restricted Project, debug-info

Oct 21 2020

n-omer updated subscribers of D89803: [dexter] Add support for Visual Studio 2019 to Dexter.
Oct 21 2020, 6:03 AM · Restricted Project, debug-info
n-omer updated subscribers of D89462: [debuginfo-tests] [dexter] Add tests to check debug experience.
Oct 21 2020, 6:03 AM · Restricted Project, debug-info
n-omer updated subscribers of D89873: [debuginfo-tests] [dexter] Add test to check debug experience with __attribute__((optnone)).
Oct 21 2020, 6:01 AM · Restricted Project, debug-info
n-omer updated the summary of D89873: [debuginfo-tests] [dexter] Add test to check debug experience with __attribute__((optnone)).
Oct 21 2020, 5:51 AM · Restricted Project, debug-info
n-omer requested review of D89873: [debuginfo-tests] [dexter] Add test to check debug experience with __attribute__((optnone)).
Oct 21 2020, 5:49 AM · Restricted Project, debug-info

Oct 20 2020

n-omer requested review of D89803: [dexter] Add support for Visual Studio 2019 to Dexter.
Oct 20 2020, 9:22 AM · Restricted Project, debug-info

Oct 19 2020

n-omer requested review of D89689: [debuginfo-tests] [dexter] Add missing entries to the dexter docs table of contents.
Oct 19 2020, 4:56 AM · debug-info
n-omer updated the diff for D89462: [debuginfo-tests] [dexter] Add tests to check debug experience.

Format code with clang-format LLVM style.

Oct 19 2020, 3:18 AM · Restricted Project, debug-info

Oct 15 2020

n-omer requested review of D89462: [debuginfo-tests] [dexter] Add tests to check debug experience.
Oct 15 2020, 6:37 AM · Restricted Project, debug-info