This is an archive of the discontinued LLVM Phabricator instance.

[InstCombine] Canonicalize GEP of GEP by swapping constant-indexed GEP to the back
AbandonedPublic

Authored by huangjd on May 19 2022, 4:10 PM.

Details

Summary

Canonicalize GEP of GEP by swapping GEP with some suffix constant indices to the back (and GEP with all constant indices to the back of that), this allows more constant index GEP merging to happen. Exceptions are: If swapping violates use-def relations, or anti-optimizes LICM

Originally D125845, clean up revision mess

Diff Detail

Event Timeline

huangjd created this revision.May 19 2022, 4:10 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 19 2022, 4:10 PM
huangjd requested review of this revision.May 19 2022, 4:10 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 19 2022, 4:10 PM
nikic added a comment.May 20 2022, 1:12 AM

Can you please refrain from submitting new revisions for the same change all the time? It loses the entire review history, and makes it hard to continue existing conversation threads, because all the context is lost.

If you are unable to get arc to work properly, please just switch to a manual patch upload workflow using git show -U99999. That's what I use myself.

Can we restore review thread https://reviews.llvm.org/D125845 instead?