This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] Enforce alignment of image vaddr on gfx90a
ClosedPublic

Authored by rampitec on May 19 2022, 1:04 PM.

Details

Summary

Even though single address image instructions only use a single VGPR
HW accesses 4 or 5 which creates alignment requirement.

Fixes: SWDEV-316648

Diff Detail

Event Timeline

rampitec created this revision.May 19 2022, 1:04 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 19 2022, 1:04 PM
rampitec requested review of this revision.May 19 2022, 1:04 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 19 2022, 1:04 PM
Herald added a subscriber: wdng. · View Herald Transcript

This looks good. Just a couple of minor comments.

llvm/lib/Target/AMDGPU/SIInstrInfo.cpp
8442

This method returns bool, but none of the callers check the result.

llvm/lib/Target/AMDGPU/SIInstrInfo.h
1156

spelling, regardless

llvm/test/CodeGen/AMDGPU/llvm.amdgcn.image.sample.dim.gfx90a.ll
73

Is this pattern correct? I believe it would allow v21 for example.

rampitec updated this revision to Diff 431430.May 23 2022, 11:00 AM
rampitec marked 3 inline comments as done.

Addressed review comments.

bcahoon accepted this revision.May 24 2022, 9:42 AM
This revision is now accepted and ready to land.May 24 2022, 9:42 AM
This revision was landed with ongoing or failed builds.May 24 2022, 10:06 AM
This revision was automatically updated to reflect the committed changes.