fixed a return curr_symbol() for Russian in the libcxx/test/support/locale_helpers.h for AIX
Details
Details
- Reviewers
hubert.reinterpretcast daltenty Mordante xingxue - Group Reviewers
Restricted Project - Commits
- rG4ac058912283: [libc++][CI] fixed a return curr_symbol() for Russian in the…
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
Thanks for the fix! I see several other monetary tests using the Russian locale that fail for AIX.
I'm not sure whether they fail on the Russian or another locale. So I'd like to see the CI green before approving.
Comment Actions
The CI is green so LGTM! Please wait a few days before landing so the AIX maintainers can have a look too.
Comment Actions
About the commit message:
Reviewers: David Tenty,Mark de Wever
The canonical tag is: Reviewed by.
In addition, Summary: should be removed as it adds no value to the message.
Since the subject says fixed a return curr_symbol() for Russian in the libcxx/test/support/locale_helpers.h for AIX, it's redundant to repeat it in the body of the commit message.