This is an archive of the discontinued LLVM Phabricator instance.

[libc++][CI] fixed a return curr_symbol() for Russian in the libcxx/test/support/locale_helpers.h for AIX
ClosedPublic

Authored by DiggerLin on May 17 2022, 8:53 AM.

Details

Summary

fixed a return curr_symbol() for Russian in the libcxx/test/support/locale_helpers.h for AIX

Diff Detail

Event Timeline

DiggerLin created this revision.May 17 2022, 8:53 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 17 2022, 8:53 AM
Herald added a subscriber: krytarowski. · View Herald Transcript
DiggerLin requested review of this revision.May 17 2022, 8:53 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 17 2022, 8:53 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript

Thanks for the fix! I see several other monetary tests using the Russian locale that fail for AIX.
I'm not sure whether they fail on the Russian or another locale. So I'd like to see the CI green before approving.

Mordante accepted this revision.May 17 2022, 11:12 AM

The CI is green so LGTM! Please wait a few days before landing so the AIX maintainers can have a look too.

This revision is now accepted and ready to land.May 17 2022, 11:12 AM
daltenty accepted this revision.May 18 2022, 6:40 AM

LGTM, thanks!

MaskRay added a subscriber: MaskRay.EditedMay 18 2022, 1:52 PM

About the commit message:

Reviewers: David Tenty,Mark de Wever

The canonical tag is: Reviewed by.

In addition, Summary: should be removed as it adds no value to the message.

Since the subject says fixed a return curr_symbol() for Russian in the libcxx/test/support/locale_helpers.h for AIX, it's redundant to repeat it in the body of the commit message.