This is an archive of the discontinued LLVM Phabricator instance.

[sanitizer] Add the common FreeBSD AArch64 support
ClosedPublic

Authored by andrew on May 17 2022, 3:29 AM.

Details

Reviewers
vitalybuka
Group Reviewers
Restricted Project
Commits
rG9496e39b4a83: [compiler-rt] Add the common FreeBSD AArch64 support

Diff Detail

Event Timeline

andrew created this revision.May 17 2022, 3:29 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 17 2022, 3:29 AM
andrew requested review of this revision.May 17 2022, 3:29 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 17 2022, 3:29 AM
vitalybuka added inline comments.
compiler-rt/lib/sanitizer_common/sanitizer_linux.cpp
1792

how about SANITIZER_NETBSD and solaris?

can you switch to:

#if SANITIZER_FREEBSD && defined(aarch64)
#elif defined(aarch64)
#endif

1890

this exclude other without explanation
for freebsd you don't need to change this line at all?

andrew added inline comments.Jun 1 2022, 4:37 AM
compiler-rt/lib/sanitizer_common/sanitizer_linux.cpp
1792

Are they supported in the sanitizers on AArch64? NetBSD doesn't have a __reserved field in its mcontext_t so will fail to build, and I don't see any ports of Solaris to AArch64.

andrew updated this revision to Diff 433364.Jun 1 2022, 5:37 AM

Remove an unneeded SANITIZER_LINUX | SANITIZER_FREEBSD check

andrew updated this revision to Diff 433381.Jun 1 2022, 6:59 AM

Rebase past rename to SANITIZER_APPLE

vitalybuka accepted this revision.Jun 7 2022, 4:59 PM
This revision is now accepted and ready to land.Jun 7 2022, 4:59 PM
This revision was landed with ongoing or failed builds.Jun 8 2022, 2:23 PM
This revision was automatically updated to reflect the committed changes.