This is an archive of the discontinued LLVM Phabricator instance.

Differential D125697

[mlir:toy][NFC] Remove unnecessary trailing return type
ClosedPublic

Authored by kuhar on May 16 2022, 8:51 AM.

Details

Reviewers
rriddle
mehdi_amini
grosser
Commits
rGffc3a0db003f: [mlir:toy][NFC] Remove unnecessary trailing return type
Summary

In this instance, the trailing return type does not improve readability as it repeats what is returned in the same line.

Diff Detail

Event Timeline

kuhar created this revision.May 16 2022, 8:51 AM
Herald added a reviewer: grosser. · View Herald TranscriptMay 16 2022, 8:51 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: sdasgup3, wenzhicui, wrengr and 17 others. · View Herald Transcript
kuhar requested review of this revision.May 16 2022, 8:51 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 16 2022, 8:51 AM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
Harbormaster completed remote builds in B164657: Diff 429730.May 16 2022, 9:22 AM
rriddle accepted this revision.May 16 2022, 9:41 AM
This revision is now accepted and ready to land.May 16 2022, 9:41 AM
Closed by commit rGffc3a0db003f: [mlir:toy][NFC] Remove unnecessary trailing return type (authored by kuhar). · Explain WhyMay 16 2022, 10:47 AM
This revision was automatically updated to reflect the committed changes.
kuhar added a commit: rGffc3a0db003f: [mlir:toy][NFC] Remove unnecessary trailing return type.

Revision Contents

PathSize
mlir/
examples/
toy/
Ch1/
include/
toy/
4 lines
Ch2/
include/
toy/
4 lines
Ch3/
include/
toy/
4 lines
Ch4/
include/
toy/
4 lines
Ch5/
include/
toy/
4 lines
Ch6/
include/
toy/
4 lines
Ch7/
include/
toy/
4 lines

Diff 429780

mlir/examples/toy/Ch1/include/toy/AST.h

Show First 20 Lines • Show All 228 Lines • ▼ Show 20 Lines
/// This class represents a list of functions to be processed together /// This class represents a list of functions to be processed together
class ModuleAST { class ModuleAST {
std::vector<FunctionAST> functions; std::vector<FunctionAST> functions;
public: public:
ModuleAST(std::vector<FunctionAST> functions) ModuleAST(std::vector<FunctionAST> functions)
: functions(std::move(functions)) {} : functions(std::move(functions)) {}
auto begin() -> decltype(functions.begin()) { return functions.begin(); } auto begin() { return functions.begin(); }
auto end() -> decltype(functions.end()) { return functions.end(); } auto end() { return functions.end(); }
}; };
void dump(ModuleAST &); void dump(ModuleAST &);
} // namespace toy } // namespace toy
#endif // TOY_AST_H #endif // TOY_AST_H

mlir/examples/toy/Ch2/include/toy/AST.h

Show First 20 Lines • Show All 228 Lines • ▼ Show 20 Lines
/// This class represents a list of functions to be processed together /// This class represents a list of functions to be processed together
class ModuleAST { class ModuleAST {
std::vector<FunctionAST> functions; std::vector<FunctionAST> functions;
public: public:
ModuleAST(std::vector<FunctionAST> functions) ModuleAST(std::vector<FunctionAST> functions)
: functions(std::move(functions)) {} : functions(std::move(functions)) {}
auto begin() -> decltype(functions.begin()) { return functions.begin(); } auto begin() { return functions.begin(); }
auto end() -> decltype(functions.end()) { return functions.end(); } auto end() { return functions.end(); }
}; };
void dump(ModuleAST &); void dump(ModuleAST &);
} // namespace toy } // namespace toy
#endif // TOY_AST_H #endif // TOY_AST_H

mlir/examples/toy/Ch3/include/toy/AST.h

Show First 20 Lines • Show All 228 Lines • ▼ Show 20 Lines
/// This class represents a list of functions to be processed together /// This class represents a list of functions to be processed together
class ModuleAST { class ModuleAST {
std::vector<FunctionAST> functions; std::vector<FunctionAST> functions;
public: public:
ModuleAST(std::vector<FunctionAST> functions) ModuleAST(std::vector<FunctionAST> functions)
: functions(std::move(functions)) {} : functions(std::move(functions)) {}
auto begin() -> decltype(functions.begin()) { return functions.begin(); } auto begin() { return functions.begin(); }
auto end() -> decltype(functions.end()) { return functions.end(); } auto end() { return functions.end(); }
}; };
void dump(ModuleAST &); void dump(ModuleAST &);
} // namespace toy } // namespace toy
#endif // TOY_AST_H #endif // TOY_AST_H

mlir/examples/toy/Ch4/include/toy/AST.h

Show First 20 Lines • Show All 228 Lines • ▼ Show 20 Lines
/// This class represents a list of functions to be processed together /// This class represents a list of functions to be processed together
class ModuleAST { class ModuleAST {
std::vector<FunctionAST> functions; std::vector<FunctionAST> functions;
public: public:
ModuleAST(std::vector<FunctionAST> functions) ModuleAST(std::vector<FunctionAST> functions)
: functions(std::move(functions)) {} : functions(std::move(functions)) {}
auto begin() -> decltype(functions.begin()) { return functions.begin(); } auto begin() { return functions.begin(); }
auto end() -> decltype(functions.end()) { return functions.end(); } auto end() { return functions.end(); }
}; };
void dump(ModuleAST &); void dump(ModuleAST &);
} // namespace toy } // namespace toy
#endif // TOY_AST_H #endif // TOY_AST_H

mlir/examples/toy/Ch5/include/toy/AST.h

Show First 20 Lines • Show All 228 Lines • ▼ Show 20 Lines
/// This class represents a list of functions to be processed together /// This class represents a list of functions to be processed together
class ModuleAST { class ModuleAST {
std::vector<FunctionAST> functions; std::vector<FunctionAST> functions;
public: public:
ModuleAST(std::vector<FunctionAST> functions) ModuleAST(std::vector<FunctionAST> functions)
: functions(std::move(functions)) {} : functions(std::move(functions)) {}
auto begin() -> decltype(functions.begin()) { return functions.begin(); } auto begin() { return functions.begin(); }
auto end() -> decltype(functions.end()) { return functions.end(); } auto end() { return functions.end(); }
}; };
void dump(ModuleAST &); void dump(ModuleAST &);
} // namespace toy } // namespace toy
#endif // TOY_AST_H #endif // TOY_AST_H

mlir/examples/toy/Ch6/include/toy/AST.h

Show First 20 Lines • Show All 228 Lines • ▼ Show 20 Lines
/// This class represents a list of functions to be processed together /// This class represents a list of functions to be processed together
class ModuleAST { class ModuleAST {
std::vector<FunctionAST> functions; std::vector<FunctionAST> functions;
public: public:
ModuleAST(std::vector<FunctionAST> functions) ModuleAST(std::vector<FunctionAST> functions)
: functions(std::move(functions)) {} : functions(std::move(functions)) {}
auto begin() -> decltype(functions.begin()) { return functions.begin(); } auto begin() { return functions.begin(); }
auto end() -> decltype(functions.end()) { return functions.end(); } auto end() { return functions.end(); }
}; };
void dump(ModuleAST &); void dump(ModuleAST &);
} // namespace toy } // namespace toy
#endif // TOY_AST_H #endif // TOY_AST_H

mlir/examples/toy/Ch7/include/toy/AST.h

Show First 20 Lines • Show All 295 Lines • ▼ Show 20 Lines
/// This class represents a list of functions to be processed together /// This class represents a list of functions to be processed together
class ModuleAST { class ModuleAST {
std::vector<std::unique_ptr<RecordAST>> records; std::vector<std::unique_ptr<RecordAST>> records;
public: public:
ModuleAST(std::vector<std::unique_ptr<RecordAST>> records) ModuleAST(std::vector<std::unique_ptr<RecordAST>> records)
: records(std::move(records)) {} : records(std::move(records)) {}
auto begin() -> decltype(records.begin()) { return records.begin(); } auto begin() { return records.begin(); }
auto end() -> decltype(records.end()) { return records.end(); } auto end() { return records.end(); }
}; };
void dump(ModuleAST &); void dump(ModuleAST &);
} // namespace toy } // namespace toy
#endif // TOY_AST_H #endif // TOY_AST_H