This is an archive of the discontinued LLVM Phabricator instance.

Differential D125569

[AMDGPU] Mark sendmsg hasSideEffects. NFC
ClosedPublic

Authored by Joe_Nash on May 13 2022, 10:32 AM.

Details

Reviewers
foad
Commits
rG6ef17f20d940: [AMDGPU] Mark sendmsg hasSideEffects. NFC
Summary

Address the FIXME by marking the sendmsg instructions with
hasSideEffects.

Diff Detail

Unit TestsFailed

TimeTest
60,100 msx64 debian > ThreadSanitizer-x86_64.ThreadSanitizer-x86_64::restore_stack.cpp
60,040 msx64 debian > libFuzzer.libFuzzer::value-profile-load.test

Event Timeline

Joe_Nash created this revision.May 13 2022, 10:32 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 13 2022, 10:32 AM
Herald added subscribers: kosarev, hsmhsm, kerbowa and 8 others. · View Herald Transcript
Joe_Nash requested review of this revision.May 13 2022, 10:32 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 13 2022, 10:32 AM
Herald added subscribers: llvm-commits, wdng. · View Herald Transcript
Joe_Nash mentioned this in D125498: [AMDGPU] gfx11 scalar alu instructions.May 13 2022, 10:34 AM
foad accepted this revision.May 13 2022, 12:13 PM

LGTM since it matches the intrinsics now. Thanks!

This revision is now accepted and ready to land.May 13 2022, 12:13 PM
Harbormaster completed remote builds in B164351: Diff 429290.May 13 2022, 12:18 PM
This revision was landed with ongoing or failed builds.May 16 2022, 7:27 AM
Closed by commit rG6ef17f20d940: [AMDGPU] Mark sendmsg hasSideEffects. NFC (authored by Joe_Nash). · Explain Why
This revision was automatically updated to reflect the committed changes.
Joe_Nash added a commit: rG6ef17f20d940: [AMDGPU] Mark sendmsg hasSideEffects. NFC.

Revision Contents

PathSize
llvm/
lib/
Target/
AMDGPU/
9 lines

Diff 429290

llvm/lib/Target/AMDGPU/SOPInstructions.td

Show First 20 Lines • Show All 1,278 Lines • ▼ Show 20 Lines
} }
def S_SETPRIO : SOPP_Pseudo <"s_setprio", (ins i16imm:$simm16), "$simm16", def S_SETPRIO : SOPP_Pseudo <"s_setprio", (ins i16imm:$simm16), "$simm16",
[(int_amdgcn_s_setprio timm:$simm16)]> { [(int_amdgcn_s_setprio timm:$simm16)]> {
let hasSideEffects = 1; let hasSideEffects = 1;
} }
let Uses = [EXEC, M0] in { let Uses = [EXEC, M0] in {
// FIXME: Should this be mayLoad+mayStore?
def S_SENDMSG : SOPP_Pseudo <"s_sendmsg" , (ins SendMsgImm:$simm16), "$simm16", def S_SENDMSG : SOPP_Pseudo <"s_sendmsg" , (ins SendMsgImm:$simm16), "$simm16",
[(int_amdgcn_s_sendmsg (i32 timm:$simm16), M0)]>; [(int_amdgcn_s_sendmsg (i32 timm:$simm16), M0)]> {
let hasSideEffects = 1;
}
def S_SENDMSGHALT : SOPP_Pseudo <"s_sendmsghalt" , (ins SendMsgImm:$simm16), "$simm16", def S_SENDMSGHALT : SOPP_Pseudo <"s_sendmsghalt" , (ins SendMsgImm:$simm16), "$simm16",
[(int_amdgcn_s_sendmsghalt (i32 timm:$simm16), M0)]>; [(int_amdgcn_s_sendmsghalt (i32 timm:$simm16), M0)]> {
let hasSideEffects = 1;
}
} // End Uses = [EXEC, M0] } // End Uses = [EXEC, M0]
def S_TRAP : SOPP_Pseudo <"s_trap" , (ins i16imm:$simm16), "$simm16"> { def S_TRAP : SOPP_Pseudo <"s_trap" , (ins i16imm:$simm16), "$simm16"> {
let isTrap = 1; let isTrap = 1;
} }
def S_ICACHE_INV : SOPP_Pseudo <"s_icache_inv", (ins)> { def S_ICACHE_INV : SOPP_Pseudo <"s_icache_inv", (ins)> {
▲ Show 20 Lines • Show All 733 Lines • Show Last 20 Lines