Page MenuHomePhabricator

[BOLT][CMAKE] Fix DYLIB build
ClosedPublic

Authored by Amir on May 13 2022, 10:30 AM.

Details

Summary

Move BOLT libraries out of LLVM_LINK_COMPONENTS to target_link_libraries.
Addresses issue #55432.

Diff Detail

Event Timeline

Amir created this revision.May 13 2022, 10:30 AM
Herald added a reviewer: maksfb. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Amir published this revision for review.May 13 2022, 11:20 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 13 2022, 11:20 AM
This revision is now accepted and ready to land.May 13 2022, 11:31 AM

LGTM, I've backported this to the release/14.x branch at https://reviews.llvm.org/D125577 (but not sure how to make Phabricator realize that one is supposed to go on a branch).

Amir added a comment.May 13 2022, 12:44 PM

LGTM, I've backported this to the release/14.x branch at https://reviews.llvm.org/D125577 (but not sure how to make Phabricator realize that one is supposed to go on a branch).

If you submit the patch using Arcanist it sets the base commit. Pre-merge checks should then be able to apply the commit. AFAIU Phabricator doesn't know about branches, you just push it to the right remote branch.

This revision was automatically updated to reflect the committed changes.