Page MenuHomePhabricator

[AMDGPU] Extract SIInstrInfo::removeModOperands. NFC.
ClosedPublic

Authored by foad on May 13 2022, 10:21 AM.

Details

Summary

Make this an externally callable function for use in a future patch.

Diff Detail

Event Timeline

foad created this revision.May 13 2022, 10:21 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 13 2022, 10:21 AM
foad requested review of this revision.May 13 2022, 10:21 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 13 2022, 10:21 AM
arsenm added inline comments.May 13 2022, 10:33 AM
llvm/lib/Target/AMDGPU/SIInstrInfo.cpp
2903–2906

Don’t see the point of this being a function instead of a global constexpr

foad updated this revision to Diff 429534.May 15 2022, 6:23 AM

Make ModifierOpNames a constexpr.

arsenm accepted this revision.May 16 2022, 1:33 AM
This revision is now accepted and ready to land.May 16 2022, 1:33 AM
This revision was landed with ongoing or failed builds.May 16 2022, 1:52 AM
This revision was automatically updated to reflect the committed changes.