Page MenuHomePhabricator

[APInt] Deprecate truncOrSelf, zextOrSelf and sextOrSelf
ClosedPublic

Authored by foad on May 13 2022, 9:11 AM.

Diff Detail

Event Timeline

foad created this revision.May 13 2022, 9:11 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 13 2022, 9:11 AM
foad requested review of this revision.May 13 2022, 9:11 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 13 2022, 9:11 AM
lattner accepted this revision.May 13 2022, 10:54 AM

This is great in concept but I think we have macros to deprecate things in compiler.h, please also make sure all in tree uses are removed before landing this. Are there any APInt docs or comments that need to be updated? Are you keeping APSInt in sync as well?

This revision is now accepted and ready to land.May 13 2022, 10:54 AM
foad added a comment.May 13 2022, 12:20 PM

This is great in concept but I think we have macros to deprecate things in compiler.h,

The first version of this patch used LLVM_ATTRIBUTE_DEPRECATED but that was removed recently in favour of the standard [[deprecated]]: D94219, 903c30f4d1f3bc0d1aae9ca83af17c0062d02b40

please also make sure all in tree uses are removed before landing this.

Should be done in D125557.

Are there any APInt docs or comments that need to be updated?

I don't think so, at least I couldn't find any other mentions of the truncOrSelf etc names in the whole monorepo.

Are you keeping APSInt in sync as well?

APSInt never had these methods, so I don't think there's anything to do there.

Ok, awesome!

This revision was landed with ongoing or failed builds.May 19 2022, 3:33 AM
This revision was automatically updated to reflect the committed changes.