Part of initial Arm64EC patchset.
Don't try to duplicate the existing logic; instead, just call the actual code we use for native x64.
efriedma on May 11 2022, 1:55 PM.Authored by
Just realized I forgot to add tests for va_arg.
I think this looks reasonable to me - if noone else has time to approve it, I guess I could, but I'd rather have the more authoritative reviewers complete their reviews.
I don't have the expertise to approve, but one question.
Why is there more testing in the .c than in .cpp. Is the same logic being used for both so there's no point checking twice?
If so what things is the .cpp test looking for specifically? I struggle to see how the lines it checks for map into the call to the variadic function. Is it looking at the mangling, the choice of pointer or not?