This is an archive of the discontinued LLVM Phabricator instance.

[mlir][vector] NFC change to improve doc of vector distribution op
ClosedPublic

Authored by ThomasRaoux on May 9 2022, 6:25 AM.

Details

Summary

Improve doc based on post commit review from https://reviews.llvm.org/D123703
Add more details on the op semantic, explicitly mention what part are parallel
and what parts are serial

Diff Detail

Event Timeline

ThomasRaoux created this revision.May 9 2022, 6:25 AM
Herald added a project: Restricted Project. · View Herald Transcript
ThomasRaoux requested review of this revision.May 9 2022, 6:25 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 9 2022, 6:25 AM

@nicolasvasilache, this patch addresses the comments you had in https://reviews.llvm.org/D123703. It is not clear to me if you think we should rename the op and operands to replace warp and lane terms to make it less GPU specific. Let me know what you think.
I didn't change verifyDistributedType because it would require computing the implicit distribution that would require verifying that the types are compatible. This will get decoupled once the distribution is explicit in the op.

mravishankar resigned from this revision.May 10 2022, 9:02 AM
nicolasvasilache accepted this revision.Jul 19 2022, 8:38 AM

Sorry for the delay, I am going through my queue.
These seem like worthy doc improvements.

This revision is now accepted and ready to land.Jul 19 2022, 8:38 AM