[BOLT][NFC] ICP: simplify findTargetsIndex

[Amir]

Summary

Unnest lambda and use llvm::is_contained.

[rafauler]

LGTM

bolt/lib/Passes/IndirectCallPromotion.cpp

for (size_t I = 0; I < N; ++I) {
       SymTargets.emplace_back(Targets[I].To.Sym, 0);
     }
     return SymTargets;
   }
 
   JumpTableInfoType HotTargets =
       maybeGetHotJumpTableTargets(BB, CallInst, TargetFetchInst, JT);
 
-  if (!HotTargets.empty()) {
-    auto findTargetsIndex = [&](uint64_t JTIndex) {
-      for (size_t I = 0; I < Targets.size(); ++I) {
-        std::vector<uint64_t> &JTIs = Targets[I].JTIndices;
-        if (std::find(JTIs.begin(), JTIs.end(), JTIndex) != JTIs.end())
-          return I;
-      }
-      LLVM_DEBUG(
-          dbgs() << "BOLT-ERROR: Unable to find target index for hot jump "
+    for (size_t I = 0; I < Targets.size(); ++I)
+      if (llvm::is_contained(Targets[I].JTIndices, JTIndex))
+    LLVM_DEBUG(dbgs() << "BOLT-ERROR: Unable to find target index for hot jump "
                       << " table entry in " << *BB.getFunction() << "\n");
-      llvm_unreachable("Hot indices must be referred to by at least one "
-                       "callsite");
-    };
 
+  if (!HotTargets.empty()) {
     if (opts::Verbosity >= 1)
       for (size_t I = 0; I < HotTargets.size(); ++I)
         outs() << "BOLT-INFO: HotTarget[" << I << "] = (" << HotTargets[I].first
                << ", " << HotTargets[I].second << ")\n";
 
     // Recompute hottest targets, now discriminating which index is hot
     // NOTE: This is a tradeoff. On one hand, we get index information. On the
     // other hand, info coming from the memory profile is much less accurate