Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
A fake def seems like a bug to me for which I have the only excuse: no one really used it. This might be OK in asm, but certainty not in the MIR instructions stream.
This changes asm syntax though.
Did these instructions just not actually have vdata?
llvm/lib/Target/AMDGPU/BUFInstructions.td | ||
---|---|---|
497 | Extra space after outs |
Yes, they don't. These are DMA. They read vmem and write LDS without touching any VGPRs. That's the whole point for these to exist.
buffer_store_lds does not have it, any of flat DMA instructions don't. This is just the old bug.
llvm/lib/Target/AMDGPU/BUFInstructions.td | ||
---|---|---|
497 | Did we finally fixed the issue when this extra space was needed? |
llvm/lib/Target/AMDGPU/BUFInstructions.td | ||
---|---|---|
497 | Not sure |
llvm/lib/Target/AMDGPU/BUFInstructions.td | ||
---|---|---|
497 | Apparently we did. Removed space. |
llvm/test/MC/AMDGPU/gfx7_asm_mubuf.s | ||
---|---|---|
102 | Can you explain this? Does the lds version of this instruction not exist at allon gfx7? Or does it just need different operands? |
llvm/test/MC/AMDGPU/gfx7_asm_mubuf.s | ||
---|---|---|
102 | It does not exist. |
Extra space after outs