This is an archive of the discontinued LLVM Phabricator instance.

[MC][NFC] Ensure tests that intended to cover compact unwind code paths do so
ClosedPublic

Authored by int3 on Apr 20 2022, 2:24 PM.

Details

Summary

These two tests were intended to cover the CU code paths, but invoked
llvm-mc using a generic "darwin" platform. However, MC only attempts to
emit CU for macos >= 10.6 [1]. Thus we adjust the tests accordingly.

compact-unwind-cfi_def_cfa.s was added in 2fca51d3b45efcf00ffcfe2879cd6d7d98c26258
fp-setup-macho.s was added in 03ffa797ad4fe8f85da532aa3f687841a60b4c0c

[1]: https://github.com/llvm/llvm-project/blob/16c93aaa4a955676fe05f876bd036719a1b14b2d/llvm/lib/MC/MCObjectFileInfo.cpp#L43

Diff Detail

Event Timeline

int3 created this revision.Apr 20 2022, 2:24 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 20 2022, 2:24 PM
Herald added a subscriber: StephenFan. · View Herald Transcript
int3 requested review of this revision.Apr 20 2022, 2:24 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 20 2022, 2:24 PM
smeenai accepted this revision.Apr 20 2022, 2:35 PM
smeenai added a subscriber: smeenai.

LGTM

I thought macosx was more common in triples than macos, but it doesn't mater very much if the latter works :)

This revision is now accepted and ready to land.Apr 20 2022, 2:35 PM
MaskRay accepted this revision.Apr 20 2022, 2:48 PM
This revision was landed with ongoing or failed builds.Apr 20 2022, 3:11 PM
This revision was automatically updated to reflect the committed changes.
thakis added a subscriber: thakis.Apr 22 2022, 4:39 AM

LGTM

I thought macosx was more common in triples than macos, but it doesn't mater very much if the latter works :)

The OS used to be called "Mac OS X", but now it's called "macOS". Hence, "macosx" is the old spelling, and it's more common because it's been around longer. But "macos" is what matches the current product name.