This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU: Defer creation of WWM VGPR spill slots
ClosedPublic

Authored by arsenm on Apr 18 2022, 7:13 AM.

Details

Reviewers
sebastian-ne
Group Reviewers
Restricted Project
Summary

There's no reason to create these immediately. They can be created in
the prolog/epilog code like CSR spills. There's probably a cleaner way
to do this by utilizing the CSR spill code.

This makes the frame index used transient state for
PrologEpilogInserter, and thus makes serialization easier. Really this
doesn't need to be saved here but there isn't really a better place
for it.

Diff Detail

Event Timeline

arsenm created this revision.Apr 18 2022, 7:13 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 18 2022, 7:13 AM
arsenm requested review of this revision.Apr 18 2022, 7:13 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 18 2022, 7:13 AM
Herald added a subscriber: wdng. · View Herald Transcript
sebastian-ne accepted this revision.Apr 19 2022, 6:19 AM
This revision is now accepted and ready to land.Apr 19 2022, 6:19 AM