This is an archive of the discontinued LLVM Phabricator instance.

Differential D123847

[VP] Rename ISD::VP_FPROUND and ISD::VP_FPEXT
ClosedPublic

Authored by frasercrmck on Apr 15 2022, 1:47 AM.

Details

Reviewers
jacquesguan
ym1813382441
craig.topper
simoll
rogfer01
Commits
rGeafe182fdc6b: [VP] Rename ISD::VP_FPROUND and ISD::VP_FPEXT
Summary

Rename them to be more closely related to their non-VP counterparts.

Diff Detail

Unit TestsFailed

TimeTest
2,630 msx64 debian > Clang.utils/update_cc_test_checks::check-globals.test
1,720 msx64 debian > Clang.utils/update_cc_test_checks::global-hex-value-regex.test
1,690 msx64 debian > Clang.utils/update_cc_test_checks::global-value-regex.test
380 msx64 debian > HWAddressSanitizer-x86_64.TestCases/Linux::decorate-proc-maps.c
60,130 msx64 debian > MLIR.Examples/standalone::test.toy
View Full Test Results (506 Failed)

Event Timeline

frasercrmck created this revision.Apr 15 2022, 1:47 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 15 2022, 1:47 AM
Herald added subscribers: StephenFan, dexonsmith. · View Herald Transcript
frasercrmck requested review of this revision.Apr 15 2022, 1:47 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 15 2022, 1:47 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
frasercrmck mentioned this in D123841: [RISCV] Add rvv codegen support for vp.fptrunc..Apr 15 2022, 1:49 AM
jacquesguan accepted this revision.Apr 15 2022, 2:07 AM
This revision is now accepted and ready to land.Apr 15 2022, 2:07 AM
Harbormaster completed remote builds in B159799: Diff 423048.Apr 15 2022, 2:27 AM
ym1813382441 accepted this revision.Apr 15 2022, 2:44 AM
This revision was landed with ongoing or failed builds.Apr 15 2022, 8:28 AM
Closed by commit rGeafe182fdc6b: [VP] Rename ISD::VP_FPROUND and ISD::VP_FPEXT (authored by frasercrmck). · Explain Why
This revision was automatically updated to reflect the committed changes.
frasercrmck added a commit: rGeafe182fdc6b: [VP] Rename ISD::VP_FPROUND and ISD::VP_FPEXT.

Revision Contents

PathSize
llvm/
include/
llvm/
IR/
4 lines

Diff 423048

llvm/include/llvm/IR/VPIntrinsics.def

Show First 20 Lines • Show All 263 Lines • ▼ Show 20 Lines
// llvm.vp.uitofp(x,mask,vlen) // llvm.vp.uitofp(x,mask,vlen)
HELPER_REGISTER_FP_CAST_VP(uitofp, VP_UITOFP, UIToFP, 1) HELPER_REGISTER_FP_CAST_VP(uitofp, VP_UITOFP, UIToFP, 1)
// llvm.vp.sitofp(x,mask,vlen) // llvm.vp.sitofp(x,mask,vlen)
HELPER_REGISTER_FP_CAST_VP(sitofp, VP_SITOFP, SIToFP, 1) HELPER_REGISTER_FP_CAST_VP(sitofp, VP_SITOFP, SIToFP, 1)
// llvm.vp.fptrunc(x,mask,vlen) // llvm.vp.fptrunc(x,mask,vlen)
HELPER_REGISTER_FP_CAST_VP(fptrunc, VP_FPTRUNC, FPTrunc, 1) HELPER_REGISTER_FP_CAST_VP(fptrunc, VP_FP_ROUND, FPTrunc, 1)
// llvm.vp.fpext(x,mask,vlen) // llvm.vp.fpext(x,mask,vlen)
HELPER_REGISTER_FP_CAST_VP(fpext, VP_FPEXT, FPExt, 0) HELPER_REGISTER_FP_CAST_VP(fpext, VP_FP_EXTEND, FPExt, 0)
#undef HELPER_REGISTER_FP_CAST_VP #undef HELPER_REGISTER_FP_CAST_VP
// Specialized helper macro for integer type conversions. // Specialized helper macro for integer type conversions.
// <operation>(%x, %mask, %evl). // <operation>(%x, %mask, %evl).
#ifdef HELPER_REGISTER_INT_CAST_VP #ifdef HELPER_REGISTER_INT_CAST_VP
#error \ #error \
"The internal helper macro HELPER_REGISTER_INT_CAST_VP is already defined!" "The internal helper macro HELPER_REGISTER_INT_CAST_VP is already defined!"
▲ Show 20 Lines • Show All 237 Lines • Show Last 20 Lines