llvm-reduce: Clone some of the easy function properties

[arsenm]

Summary

Error on some of these other fields, since tracking down test cases
for all of these at once is exhausting.

[arsenm]

Test newly serialized fields

[arsenm]

193fde7509d7805771adaef0f34186cb2cf6e084

[dblaikie]

This comment was removed by dblaikie.

[llvm-commits]

(as you already noticed this was approved).

I bet this was manually marked because somehow our phabricator instance sometimes takes > 1 hour to recognize something as being committed and automatically add it. I also ended up manually adding a revision a couple of times thinking the automation was broken until I realized that it's just really slow.

[dblaikie]

In D123813#3494994, @llvm-commits wrote:

(as you already noticed this was approved).

I bet this was manually marked because somehow our phabricator instance sometimes takes > 1 hour to recognize something as being committed and automatically add it. I also ended up manually adding a revision a couple of times thinking the automation was broken until I realized that it's just really slow.

Yeah, the main issue is that if a patch is approved without any comment, no email is sent to the list (so, if at all possible, please include some text when approving a patch to ensure the mailing list reflects the approved status) - and then I missed it when inspecting the review itself (to look for the "approved" status update in the review log UI at the top).

llvm/include/llvm/CodeGen/MachineFunction.h

public:
   unsigned getTypeIDFor(const GlobalValue *TI);
 
   /// Return the id of the filter encoded by TyIds.  This is function wide.
   int getFilterIDFor(std::vector<unsigned> &TyIds);
 
   /// Map the landing pad's EH symbol to the call site indexes.
   void setCallSiteLandingPad(MCSymbol *Sym, ArrayRef<unsigned> Sites);
 
+  /// Return if there is any wasm exception handling.
+  bool hasAnyWasmLandingPadIndex() const {
+    return !WasmLPadToIndexMap.empty();
+  }
+
   /// Map the landing pad to its index. Used for Wasm exception handling.
   void setWasmLandingPadIndex(const MachineBasicBlock *LPad, unsigned Index) {
     WasmLPadToIndexMap[LPad] = Index;
   }
 
   /// Returns true if the landing pad has an associate index in wasm EH.
   bool hasWasmLandingPadIndex(const MachineBasicBlock *LPad) const {
     return WasmLPadToIndexMap.count(LPad);
   }
 
   /// Get the index in wasm EH for a given landing pad.
   unsigned getWasmLandingPadIndex(const MachineBasicBlock *LPad) const {
     assert(hasWasmLandingPadIndex(LPad));
     return WasmLPadToIndexMap.lookup(LPad);
   }
 
+  bool hasAnyCallSiteLandingPad() const {
+    return !LPadToCallSiteMap.empty();
+  }
+
   /// Get the call site indexes for a landing pad EH symbol.
   SmallVectorImpl<unsigned> &getCallSiteLandingPad(MCSymbol *Sym) {
     assert(hasCallSiteLandingPad(Sym) &&
            "missing call site number for landing pad!");
     return LPadToCallSiteMap[Sym];
   }
 
   /// Return true if the landing pad Eh symbol has an associated call site.
   bool hasCallSiteLandingPad(MCSymbol *Sym) {
     return !LPadToCallSiteMap[Sym].empty();
   }
 
+  bool hasAnyCallSiteLabel() const {
+    return !CallSiteMap.empty();
+  }
+
   /// Map the begin label for a call site.
   void setCallSiteBeginLabel(MCSymbol *BeginLabel, unsigned Site) {
     CallSiteMap[BeginLabel] = Site;
   }
 
   /// Get the call site number for a begin label.
   unsigned getCallSiteBeginLabel(MCSymbol *BeginLabel) const {
     assert(hasCallSiteBeginLabel(BeginLabel) &&

llvm/test/tools/llvm-reduce/mir/preserve-func-info.mir

+# REQUIRES: amdgpu-registered-target
+# RUN: llvm-reduce -simplify-mir -mtriple=amdgcn-amd-amdhsa --test FileCheck --test-arg --check-prefix=CHECK-INTERESTINGNESS --test-arg %s --test-arg --input-file %s -o %t 2> %t.log
+# RUN: FileCheck --check-prefix=RESULT %s < %t
+
+# CHECK-INTERESTINGNESS: V_MOV_B32
+
+
+# RESULT: name: func
+# RESULT-NEXT: alignment:       32
+# RESULT-NEXT: exposesReturnsTwice: true
+# RESULT-NEXT: legalized:       true
+# RESULT-NEXT: regBankSelected: true
+# RESULT-NEXT: selected:        true
+# RESULT-NEXT: failedISel:      true
+# RESULT-NEXT: tracksRegLiveness: true
+# RESULT-NEXT: hasWinCFI:       true
+# RESULT-NEXT: callsEHReturn: true
+# RESULT-NEXT: callsUnwindInit: true
+# RESULT-NEXT: hasEHCatchret: true
+# RESULT-NEXT: hasEHScopes: true
+# RESULT-NEXT: hasEHFunclets: true
+# RESULT-NEXT: failsVerification: true
+# RESULT-NEXT: tracksDebugUserValues: true
+
+# RESULT: %0:vgpr_32 = V_MOV_B32_e32 0, implicit $exec
+# RESULT-NEXT: S_ENDPGM
+
+--- |
+  define void @func(i32 %size)  {
+    ret void
+  }
+
+...
+---
+name: func
+alignment:       32
+exposesReturnsTwice: true
+legalized:       true
+regBankSelected: true
+selected:        true
+failedISel:      true
+tracksRegLiveness: true
+hasWinCFI:       true
+failsVerification: true
+tracksDebugUserValues: true
+callsEHReturn: true
+callsUnwindInit: true
+callsUnwindInit: true
+hasEHCatchret: true
+hasEHScopes: true
+hasEHFunclets: true
+
+body:             |
+  bb.0:
+    S_NOP 0
+    %0:vgpr_32 = V_MOV_B32_e32 0, implicit $exec
+    INLINEASM &"", 1 /* sideeffect attdialect */
+    S_ENDPGM 0, implicit %0
+...

llvm/tools/llvm-reduce/ReducerWorkItem.cpp

for (auto &SrcMI : SrcMBB) {
         }
 
         DstMI->addOperand(DstMO);
       }
       DstMI->setMemRefs(*DstMF, SrcMI.memoperands());
     }
   }
 
+  DstMF->setAlignment(SrcMF->getAlignment());
+  DstMF->setExposesReturnsTwice(SrcMF->exposesReturnsTwice());
+  DstMF->setHasInlineAsm(SrcMF->hasInlineAsm());
+  DstMF->setHasWinCFI(SrcMF->hasWinCFI());
+
+  DstMF->getProperties().reset().set(SrcMF->getProperties());
+
+  if (!SrcMF->getFrameInstructions().empty() ||
+      !SrcMF->getLongjmpTargets().empty() ||
+      !SrcMF->getCatchretTargets().empty())
+    report_fatal_error("cloning not implemented for machine function property");
+
+  DstMF->setCallsEHReturn(SrcMF->callsEHReturn());
+  DstMF->setCallsUnwindInit(SrcMF->callsUnwindInit());
+  DstMF->setHasEHCatchret(SrcMF->hasEHCatchret());
+  DstMF->setHasEHScopes(SrcMF->hasEHScopes());
+  DstMF->setHasEHFunclets(SrcMF->hasEHFunclets());
+
+  if (!SrcMF->getLandingPads().empty() ||
+      !SrcMF->getCodeViewAnnotations().empty() ||
+      !SrcMF->getTypeInfos().empty() ||
+      !SrcMF->getFilterIds().empty() ||
+      SrcMF->hasAnyWasmLandingPadIndex() ||
+      SrcMF->hasAnyCallSiteLandingPad() ||
+      SrcMF->hasAnyCallSiteLabel() ||
+      !SrcMF->getCallSitesInfo().empty())
+    report_fatal_error("cloning not implemented for machine function property");
+
+  DstMF->setDebugInstrNumberingCount(SrcMF->DebugInstrNumberingCount);
+
   DstMF->verify(nullptr, "", /*AbortOnError=*/true);
   return DstMF;
 }
 
 std::unique_ptr<ReducerWorkItem> parseReducerWorkItem(StringRef Filename,
                                                       LLVMContext &Ctxt,
                                                       MachineModuleInfo *MMI) {
   auto MMM = std::make_unique<ReducerWorkItem>();