This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] Use default member initializers in Subtarget classes
ClosedPublic

Authored by foad on Apr 12 2022, 8:30 AM.

Details

Summary

Use default member initializers in AMDGPUSubtarget and subclasses. This
is to guard against adding a new feature boolean in AMDGPUSubtarget.h
but forgetting to initialize it to false in AMDGPUSubtarget.cpp.

This was mostly autogenerated by:
clang-tidy -checks=-*,cppcoreguidelines-prefer-member-initializer,modernize-use-default-member-init -header-filter=Subtarget -fix lib/Target/AMDGPU/*Subtarget.cpp

Diff Detail

Event Timeline

foad created this revision.Apr 12 2022, 8:30 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 12 2022, 8:30 AM
foad requested review of this revision.Apr 12 2022, 8:30 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 12 2022, 8:30 AM
arsenm accepted this revision.Apr 12 2022, 8:40 AM

LGTM, I've meant to do this for a while

This revision is now accepted and ready to land.Apr 12 2022, 8:40 AM
This revision was landed with ongoing or failed builds.Apr 12 2022, 8:45 AM
This revision was automatically updated to reflect the committed changes.