This is an archive of the discontinued LLVM Phabricator instance.

Differential D123547

[docs] Mention that we are in the process of removing the legacy PM for the optimization pipeline
ClosedPublic

Authored by aeubanks on Apr 11 2022, 2:15 PM.

Details

Reviewers
nikic
MaskRay
ctetreau
Commits
rG9faab435a357: [docs] Mention that we are in the process of removing the legacy PM for the…
Summary

And remove references to flags to turn it off.

Diff Detail

Event Timeline

aeubanks created this revision.Apr 11 2022, 2:15 PM
Herald added a reviewer: ctetreau. · View Herald TranscriptApr 11 2022, 2:15 PM
Herald added a reviewer: ctetreau. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: StephenFan, awarzynski. · View Herald Transcript
aeubanks requested review of this revision.Apr 11 2022, 2:15 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptApr 11 2022, 2:15 PM
Herald added subscribers: llvm-commits, cfe-commits. · View Herald Transcript
nikic added inline comments.Apr 11 2022, 2:19 PM
clang/docs/ClangCommandLineReference.rst
4

See this line :)

MaskRay added inline comments.Apr 11 2022, 2:24 PM
clang/docs/ClangCommandLineReference.rst
910

This is generated by clang-tblgen. You can drop the help message from clang/include/clang/Driver/Options.td

aeubanks updated this revision to Diff 422038.Apr 11 2022, 2:32 PM

remove help text instead of modifying generated docs

aeubanks added a comment.Apr 11 2022, 2:33 PM

I tried regenerating ClangCommandLineReference.rst and it's a little out of date. I'll regenerate it in a separate change

Harbormaster completed remote builds in B159099: Diff 422038.Apr 11 2022, 3:08 PM
nikic accepted this revision.Apr 12 2022, 7:04 AM

LG

This revision is now accepted and ready to land.Apr 12 2022, 7:04 AM
MaskRay accepted this revision.Apr 12 2022, 10:47 AM
This revision was landed with ongoing or failed builds.Apr 12 2022, 10:48 AM
Closed by commit rG9faab435a357: [docs] Mention that we are in the process of removing the legacy PM for the… (authored by aeubanks). · Explain Why
This revision was automatically updated to reflect the committed changes.
aeubanks added a commit: rG9faab435a357: [docs] Mention that we are in the process of removing the legacy PM for the….

Revision Contents

PathSize
clang/
docs/
4 lines
llvm/
docs/
9 lines

Diff 422036

clang/docs/ClangCommandLineReference.rst

.. ..
------------------------------------------------------------------- -------------------------------------------------------------------
NOTE: This file is automatically generated by running clang-tblgen NOTE: This file is automatically generated by running clang-tblgen
-gen-opt-docs. Do not edit this file by hand!! -gen-opt-docs. Do not edit this file by hand!!
nikicUnsubmitted
Not Done
ReplyInline Actions

See this line :)

nikic: See this line :)
------------------------------------------------------------------- -------------------------------------------------------------------
===================================== =====================================
Clang command line argument reference Clang command line argument reference
===================================== =====================================
.. contents:: .. contents::
:local: :local:
▲ Show 20 Lines • Show All 889 Lines • ▼ Show 20 Lines
.. option:: -finline-functions, -fno-inline-functions .. option:: -finline-functions, -fno-inline-functions
Inline suitable functions Inline suitable functions
.. option:: -finline-hint-functions .. option:: -finline-hint-functions
Inline functions which are (explicitly or implicitly) marked inline Inline functions which are (explicitly or implicitly) marked inline
.. option:: -flegacy-pass-manager, -fno-legacy-pass-manager
MaskRayUnsubmitted
Not Done
ReplyInline Actions

This is generated by clang-tblgen. You can drop the help message from clang/include/clang/Driver/Options.td

MaskRay: This is generated by clang-tblgen. You can drop the help message from…
Use the legacy pass manager in LLVM (deprecated, to be removed in a future release)
.. option:: -fno-crash-diagnostics .. option:: -fno-crash-diagnostics
Disable auto-generation of preprocessed source files and a script for reproduction during a clang crash Disable auto-generation of preprocessed source files and a script for reproduction during a clang crash
.. option:: -fno-sanitize-ignorelist, -fno-sanitize-blacklist .. option:: -fno-sanitize-ignorelist, -fno-sanitize-blacklist
Don't use ignorelist file for sanitizers Don't use ignorelist file for sanitizers
▲ Show 20 Lines • Show All 3,274 Lines • Show Last 20 Lines

llvm/docs/NewPassManager.rst

Show First 20 Lines • Show All 474 Lines • ▼ Show 20 Lines
Status of the New and Legacy Pass Managers Status of the New and Legacy Pass Managers
========================================== ==========================================
LLVM currently contains two pass managers, the legacy PM and the new PM. The LLVM currently contains two pass managers, the legacy PM and the new PM. The
optimization pipeline (aka the middle-end) works with both the legacy PM and optimization pipeline (aka the middle-end) works with both the legacy PM and
the new PM, whereas the backend target-dependent code generation only works the new PM, whereas the backend target-dependent code generation only works
with the legacy PM. with the legacy PM.
For the optimization pipeline, the new PM is the default PM. The legacy PM is For the optimization pipeline, the new PM is the default PM. Using the legacy PM
available for the optimization pipeline by setting various compiler/linker for the optimization pipeline is deprecated and there are ongoing efforts to
flags, e.g. ``-flegacy-pass-manager`` for ``clang``. remove its usage.
There will be efforts to deprecate and remove the legacy PM for the
optimization pipeline in the future.
Some IR passes are considered part of the backend codegen pipeline even if Some IR passes are considered part of the backend codegen pipeline even if
they are LLVM IR passes (whereas all MIR passes are codegen passes). This they are LLVM IR passes (whereas all MIR passes are codegen passes). This
includes anything added via ``TargetPassConfig`` hooks, e.g. includes anything added via ``TargetPassConfig`` hooks, e.g.
``TargetPassConfig::addCodeGenPrepare()``. As mentioned before, passes added ``TargetPassConfig::addCodeGenPrepare()``. As mentioned before, passes added
in ``TargetMachine::adjustPassManager()`` are part of the optimization in ``TargetMachine::adjustPassManager()`` are part of the optimization
pipeline, and should have a corresponding line in pipeline, and should have a corresponding line in
``TargetMachine::registerPassBuilderCallbacks()``. ``TargetMachine::registerPassBuilderCallbacks()``.
Currently there are efforts to make the codegen pipeline work with the new Currently there are efforts to make the codegen pipeline work with the new
PM. PM.