[mlir][emitc] Add test for invalid type

[jpienaar]

mlir/test/Dialect/EmitC/invalid_types.mlir

5

This error could seemingly have been triggered by either variable name or type, the error message doesn't help much there and the test feels like either of these could be wrong.

[marbre]

mlir/test/Dialect/EmitC/invalid_types.mlir

5

mlir-opt points you to where the error occurs:

test/Dialect/EmitC/invalid_types.mlir:5:56: error: expected non empty string
    %1 = "emitc.variable"(){value = "" : !emitc.opaque<"">} : () -> !emitc.opaque<"">
                                                       ^

But I can modify the test in way that there is only one empty string:

test/Dialect/EmitC/invalid_types.mlir:5:58: error: expected non empty string
    %1 = "emitc.variable"(){value = "42" : !emitc.opaque<"">} : () -> !emitc.opaque<"mytype">
                                                         ^

Before updating the proposed patch, it seems you would prefer if I patch the error message as well, e.g. to "expected non empty string in !emitc.opaque type"?

[jpienaar]

mlir/test/Dialect/EmitC/invalid_types.mlir

5

Updating the error message too thanks

mlir/lib/Dialect/EmitC/IR/EmitC.cpp

 //===----------------------------------------------------------------------===//
 
 Type emitc::OpaqueType::parse(AsmParser &parser) {
   if (parser.parseLess())
     return Type();
   std::string value;
   SMLoc loc = parser.getCurrentLocation();
   if (parser.parseOptionalString(&value) || value.empty()) {
-    parser.emitError(loc) << "expected non empty string";
+    parser.emitError(loc) << "expected non empty string in !emitc.opaque type";
     return Type();
   }
   if (parser.parseGreater())
     return Type();
   return get(parser.getContext(), value);
 }
 
 void emitc::OpaqueType::print(AsmPrinter &printer) const {
   printer << "<\"";
   llvm::printEscapedString(getValue(), printer.getStream());
   printer << "\">";
 }

mlir/test/Dialect/EmitC/invalid_types.mlir

+// RUN: mlir-opt %s -split-input-file -verify-diagnostics
+
+func @illegal_opaque_type_1() {
+    // expected-error @+1 {{expected non empty string in !emitc.opaque type}}
+    %1 = "emitc.variable"(){value = "42" : !emitc.opaque<"">} : () -> !emitc.opaque<"mytype">
+}