This is an archive of the discontinued LLVM Phabricator instance.

[BOLT] Fix two aarch64 tests
ClosedPublic

Authored by yota9 on Apr 7 2022, 11:57 AM.

Details

Summary

tls-lld test might be broken since compiler might optimize plt function
call and use address directly from got table. The test is removed since
plt-gnu-ld checks the same functionality + versioning symbol matching,
no need to keep both of the tests.
The toolchain might optimize relocations in runtime-relocs test, replace
the test compilation with yaml files.

Diff Detail

Event Timeline

yota9 created this revision.Apr 7 2022, 11:57 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 7 2022, 11:57 AM
yota9 requested review of this revision.Apr 7 2022, 11:57 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 7 2022, 11:57 AM
yota9 retitled this revision from Fix two aarch64 tests to [BOLT] Fix two aarch64 tests.Apr 7 2022, 12:03 PM
Amir accepted this revision.Apr 8 2022, 4:21 PM
This revision is now accepted and ready to land.Apr 8 2022, 4:21 PM
Amir requested changes to this revision.EditedApr 8 2022, 4:44 PM

Sorry, just checked and still see these two tests fail: https://paste.debian.net/1237320/

Here are the artifacts (Output folder): https://filebin.net/wvvo6zd3r5czctso

This revision now requires changes to proceed.Apr 8 2022, 4:44 PM
yota9 edited the summary of this revision. (Show Details)Apr 11 2022, 11:20 AM
Amir accepted this revision.Apr 12 2022, 9:40 AM

LGTM. Thanks for fixing these tests!

This revision is now accepted and ready to land.Apr 12 2022, 9:40 AM
This revision was automatically updated to reflect the committed changes.
bolt/test/AArch64/runtime-relocs.test