This is an archive of the discontinued LLVM Phabricator instance.

Differential D123329

[BOLT][TEST] Remove -no-pie from cflags/cxxflags
ClosedPublic

Authored by Amir on Apr 7 2022, 11:28 AM.

Details

Reviewers
rafauler
maksfb
yota9
Commits
rG487570fb8600: [BOLT][TEST] Remove -no-pie from cflags/cxxflags
Summary

Align with an upstream change D120305 to make PIE the default on linux-gnu.

Add -no-pie to tests that require it.

Diff Detail

Event Timeline

Amir created this revision.Apr 7 2022, 11:28 AM
Herald added a reviewer: rafauler. · View Herald TranscriptApr 7 2022, 11:28 AM
Herald added a reviewer: maksfb. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a subscriber: ayermolo. · View Herald Transcript
Amir requested review of this revision.Apr 7 2022, 11:28 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 7 2022, 11:28 AM
Herald added subscribers: llvm-commits, yota9. · View Herald Transcript
Amir updated this revision to Diff 421325.Apr 7 2022, 1:05 PM

Update tests

Harbormaster completed remote builds in B158561: Diff 421325.Apr 7 2022, 1:05 PM
Amir retitled this revision from [BOLT][TEST] Remove -no-pie from tests to [BOLT][TEST] Remove -no-pie from cflags/cxxflags.Apr 7 2022, 1:06 PM
Amir edited the summary of this revision. (Show Details)
yota9 added a comment.Apr 8 2022, 4:50 AM

@Amir I think you need to rebase the patch, I will check it on aarch64 then :) Thank you!

Amir updated this revision to Diff 421653.Apr 8 2022, 5:28 PM

Rebase

Amir added a comment.Apr 8 2022, 5:29 PM
In D123329#3438746, @yota9 wrote:

@Amir I think you need to rebase the patch, I will check it on aarch64 then :) Thank you!

Done

Harbormaster completed remote builds in B158794: Diff 421653.Apr 8 2022, 5:34 PM
maksfb accepted this revision.Apr 13 2022, 10:25 AM

LGTM

This revision is now accepted and ready to land.Apr 13 2022, 10:25 AM
yota9 accepted this revision.Apr 13 2022, 10:38 AM
Amir updated this revision to Diff 422578.Apr 13 2022, 11:21 AM

Rebase

Harbormaster completed remote builds in B159489: Diff 422578.Apr 13 2022, 11:28 AM
Closed by commit rG487570fb8600: [BOLT][TEST] Remove -no-pie from cflags/cxxflags (authored by Amir). · Explain WhyApr 13 2022, 11:38 AM
This revision was automatically updated to reflect the committed changes.
Amir added a commit: rG487570fb8600: [BOLT][TEST] Remove -no-pie from cflags/cxxflags.
Amir mentioned this in rG04641b212191: [BOLT][TEST] Add -no-pie to two tests.Apr 13 2022, 11:48 AM

Revision Contents

PathSize
bolt/
test/
4 lines

Diff 421299

bolt/test/lit.cfg.py

Show First 20 Lines • Show All 57 Lines • ▼ Show 20 Lines
llvm_config.config.environment['CLANG'] = config.bolt_clang llvm_config.config.environment['CLANG'] = config.bolt_clang
llvm_config.use_clang() llvm_config.use_clang()
llvm_config.config.environment['LD_LLD'] = config.bolt_lld llvm_config.config.environment['LD_LLD'] = config.bolt_lld
ld_lld = llvm_config.use_llvm_tool('ld.lld', required=True, search_env='LD_LLD') ld_lld = llvm_config.use_llvm_tool('ld.lld', required=True, search_env='LD_LLD')
llvm_config.config.available_features.add('ld.lld') llvm_config.config.available_features.add('ld.lld')
llvm_config.add_tool_substitutions([ToolSubst(r'ld\.lld', command=ld_lld)]) llvm_config.add_tool_substitutions([ToolSubst(r'ld\.lld', command=ld_lld)])
config.substitutions.append(('%cflags', '-no-pie -gdwarf-4')) config.substitutions.append(('%cflags', '-gdwarf-4'))
config.substitutions.append(('%cxxflags', '-no-pie -gdwarf-4')) config.substitutions.append(('%cxxflags', '-gdwarf-4'))
link_fdata_cmd = os.path.join(config.test_source_root, 'link_fdata.py') link_fdata_cmd = os.path.join(config.test_source_root, 'link_fdata.py')
tool_dirs = [config.llvm_tools_dir, tool_dirs = [config.llvm_tools_dir,
config.test_source_root] config.test_source_root]
tools = [ tools = [
ToolSubst('llc', unresolved='fatal'), ToolSubst('llc', unresolved='fatal'),
Show All 31 Lines