This is an archive of the discontinued LLVM Phabricator instance.

[BOLT][TEST] Remove -no-pie from cflags/cxxflags
ClosedPublic

Authored by Amir on Apr 7 2022, 11:28 AM.

Details

Summary

Align with an upstream change D120305 to make PIE the default on linux-gnu.

Add -no-pie to tests that require it.

Diff Detail

Event Timeline

Amir created this revision.Apr 7 2022, 11:28 AM
Herald added a reviewer: maksfb. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a subscriber: ayermolo. · View Herald Transcript
Amir requested review of this revision.Apr 7 2022, 11:28 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 7 2022, 11:28 AM
Amir updated this revision to Diff 421325.Apr 7 2022, 1:05 PM

Update tests

Amir retitled this revision from [BOLT][TEST] Remove -no-pie from tests to [BOLT][TEST] Remove -no-pie from cflags/cxxflags.Apr 7 2022, 1:06 PM
Amir edited the summary of this revision. (Show Details)
yota9 added a comment.Apr 8 2022, 4:50 AM

@Amir I think you need to rebase the patch, I will check it on aarch64 then :) Thank you!

Amir updated this revision to Diff 421653.Apr 8 2022, 5:28 PM

Rebase

Amir added a comment.Apr 8 2022, 5:29 PM

@Amir I think you need to rebase the patch, I will check it on aarch64 then :) Thank you!

Done

maksfb accepted this revision.Apr 13 2022, 10:25 AM

LGTM

This revision is now accepted and ready to land.Apr 13 2022, 10:25 AM
yota9 accepted this revision.Apr 13 2022, 10:38 AM
This revision was automatically updated to reflect the committed changes.