The tests are currently incomplete. There are also still some other things not implemented that are required here.
Details
Details
- Reviewers
- None
- Group Reviewers
Restricted Project
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
Nice see this being worked on!
I mainly looked at the code out of curiosity, I didn't do a review.
libcxx/include/__stacktrace/basic_stacktrace.h | ||
---|---|---|
24 | Since this function is in the dylib it needs an availability macro in <__availability>. | |
libcxx/src/stacktrace/stacktrace_entry.cpp | ||
41 | When line 45 throws the pointer leaks. // Unused; the returned pointer is used to test the conversion status. int __s; unique_ptr<char, void (*)(void*)> __demangled{abi::__cxa_demangle(__name, nullptr, 0, &__s), std::free}; (I wrote this for a libc++ formatting experiment.) |
libcxx/src/stacktrace/stacktrace_entry.cpp | ||
---|---|---|
41 | Thanks, good catch! |
libcxx/src/stacktrace/stacktrace_entry.cpp | ||
---|---|---|
36 | I do not know about the libcxx coding style, but LLVM prefers static over functions in anonymous namespaces. I believe there are quite a few functions that you could make static. |